Perl Critic and a formatting question.

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

Hi monks.

In the following code:

#!\usr\bin\perl

package Test20;

use strict;
use warnings;
use autodie;
use Fcntl;
use version;
use Perl::Tidy;
use base qw/Exporter/;
our @EXPORT_OK = qw/&greet/;
our $VERSION = '0.1';
my @data;

sysopen FH, 'test.txt', O_RDONLY;
@data = <FH>;
close FH;

for (@data) {
    exit 1 if !print;
}

sub greet {
    my ($name) = shift;
    return "Hello $name";
}
1;
[download]

...perl critic complains about untidy code on column 1, row 1 if run in --brutal "mode". The complaint disappears if I remove the line our @EXPORT_OK = qw/&greet/;

Any suggestions would be appreciated.

Thanks

Comment on Perl Critic and a formatting question. Select or Download Code

Replies are listed 'Best First'.
Re: Perl Critic and a formatting question. by choroba (Cardinal) on Apr 29, 2013 at 08:27 UTC
Any suggestions would be appreciated. Do not run perlcritic in brutal mode. What's the prize? Jokes aside: Read more... (1084 Bytes) لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ	[reply] [d/l] [select]
Re^2: Perl Critic and a formatting question. by Anonymous Monk on Apr 29, 2013 at 08:50 UTC
Hi choroba. Děkuji! I should have seen that minor fix but fatigue is the culprit (1:48am here). P.S: I hope my rudimentary knowledge of Czech was correct and displayed properly in your browser. :)	[reply]
Re^2: Perl Critic and a formatting question. by B-Man (Acolyte) on Apr 30, 2013 at 17:38 UTC
Oh. I see what the complaint is about and why it disappears! Take a look at these two lines of code: `our @EXPORT_OK = qw/&greet/; our $VERSION = '0.1';` [download] The assignment operators (=) don't line up. When perltidy adds the spaces, it's creating whitespace that aligns those operators. `our @EXPORT_OK = qw/&greet/; our $VERSION = '0.1';` [download] Now the the code is tidy and the assignment operators are aligned, perlcritic stops complaining.	[reply] [d/l] [select]