Re^2: Feedback on my second script

Thanks for the feedback. I have inserted the things you suggest. About the running rsync. In the future I would send a mail to the admin if there is an error with the error message included. How could i do something like this is it possible if i use system or not?

greetings!

Comment on Re^2: Feedback on my second script

Replies are listed 'Best First'.
Re^3: Feedback on my second script by Corion (Patriarch) on May 15, 2013 at 10:19 UTC
Yes, if you want to extend the program later to send the output via mail (but only in the case of error), your current approach makes sense.	[reply]
Re: Feedback on my second script by jonadab (Parson) on May 15, 2013 at 10:47 UTC
I would send a mail... How could i do something like this I've traditionally used Mail::Sendmail for that; although, Mail::Send may also be worth considering. Note too that it's generally unsafe to allow the user to specify a destination address for mail (unless you have carefully authenticated the user). In simple cases like this, it's often best to hardcode the destination address. In more advanced cases, possible destination addresses can be stored in a configuration file or database that only system administrators can edit, and the user can be allowed to select from among them.	[reply]