Re^2: Module::Starter in Windows fails due to getpwuid() not working

I'd love to fix the bug and submit the patch. Unfortunately, I'm at about a 'grasshopper' level of coding for the most part. :-)

Thanks for the pointer to the bug tho. It's good to know I'm not going insane.

Comment on Re^2: Module::Starter in Windows fails due to getpwuid() not working

Replies are listed 'Best First'.
Re^3: Module::Starter in Windows fails due to getpwuid() not working by marto (Cardinal) on May 24, 2013 at 15:27 UTC
The test suite failed when I tried to install the module (Strawberry Perl 5.16, Windows 7 pro 64bit), I changed line 96 of Module::Starter::Simple.pm from: `if ( not $self->{author} ) {` [download] To `if ( ( not $self->{author} ) && ( $^O ne 'MSWin32' ) ) {` [download] So it'll fall through to: `croak "Must specify an author\n" unless $self->{author};` [download] rather than fall in a heap because `getpwuid` isn't implemented in this platform. So yes, you'll have to provide a value fo author, but at least this way the test suite will pass, the module will install without a force and you'll be told what to do to make it work. As I say, I'll look into the problem in more detail and submit an appropriate patch when I get home. Update: added to explanation for clarity. Update: Patch submitted.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: Module::Starter in Windows fails due to getpwuid() not working
by marto (Cardinal) on May 24, 2013 at 15:27 UTC

The test suite failed when I tried to install the module (Strawberry Perl 5.16, Windows 7 pro 64bit), I changed line 96 of Module::Starter::Simple.pm from:

if ( not $self->{author} ) {
[download]

if ( ( not $self->{author} ) && ( $^O ne 'MSWin32' ) ) {
[download]

So it'll fall through to:

croak "Must specify an author\n" unless $self->{author};
[download]

rather than fall in a heap because getpwuid isn't implemented in this platform. So yes, you'll have to provide a value fo author, but at least this way the test suite will pass, the module will install without a force and you'll be told what to do to make it work. As I say, I'll look into the problem in more detail and submit an appropriate patch when I get home.

Update: added to explanation for clarity.

Update: Patch submitted.

[reply]
[d/l]
[select]