Re^4: Testing for readdir failure (perlbug errno test without localizing)

As you can see $! needs to be reset in advance "to be meaningful".

Yup, logic bug is logic bug :)

Compare Perl_do_close (called by pp_close ie close ) to pp_readdir

pp_readdir test errno without localizing, do_close doesn't test errno at all

closedir has this issue, and probably many others, maybe 40 others

I wouldn't be surprised if other functions testing errno have this issue too -- this needs explicit testing / reviewing / patching

Comment on Re^4: Testing for readdir failure (perlbug errno test without localizing)

Replies are listed 'Best First'.
Re^5: Testing for readdir failure (perlbug errno test without localizing) by LanX (Saint) on May 26, 2013 at 00:56 UTC
> closedir has this issue, and probably many others, maybe 40 others well at least readline, but now setting to `undef` doesn't help here. Additionally I couldn't figure out why readdir sometimes throws warnings and sometimes not. I already prepared a bug report and will send it tomorrow. Cheers Rolf ( addicted to the Perl Programming Language)	[reply] [d/l]
Re^5: Testing for readdir failure (perlbug errno test without localizing) by Bob Cook (Acolyte) on May 30, 2013 at 20:38 UTC
I have practically no knowledge of C nor Perl's C code, so could you describe the effect(s) of this logic bug at the Perl level?	[reply]