id007 has asked for the wisdom of the Perl Monks concerning the following question:

The following line throws error, don't know why.

    
my $stmt = join " ", "select * from dbo.server" , ($orderby) ? ";","or
+der by $orderby;" ;

[download]

Replies are listed 'Best First'.
Re: Using join and ternary operator together
by Corion (Patriarch) on Sep 10, 2013 at 11:17 UTC

    What error does it throw?

    Maybe you want to look at what the ternary operator does (in perlop), and how it is spelled?

[reply]
Re: Using join and ternary operator together
by hdb (Monsignor) on Sep 10, 2013 at 11:27 UTC

    ... check your punctuation ...

[reply]
[reply]
[d/l]
Re: Using join and ternary operator together
by id007 (Initiate) on Sep 11, 2013 at 02:50 UTC
    Thanks all for the replies. My syntax and logic both were incorrect. The working code is this: my $stmt = join " ", "select * from dbo.server" , defined($orderby) ? "order by $orderby;" : ";" ;
[reply]
[d/l]

      Just a pet peeve for the most part, but I prefer using parens even when they are not strictly needed just to improve clarity of intent. Seems to help me, anyway. 

      my $stmt = join(" ", "select * from dbo.server" , (defined($orderby) ?
+ "order by $orderby;" : ";"));

      [download]

      On a side note, I presume you have a space in front of the word "order" in your true clause. I.e. " order by $orderby;" or else you would wind up with SQL that read something like this: select * from dbo.serverorder by .... That would clearly be wrong.

[reply]
[d/l]
[select]
        ... a space in front of the word "order" in your true clause.

        That space would be supplied by the  " " join string of the join function.

[reply]
[d/l]

Back to Seekers of Perl Wisdom