Re^5: RFC: beginner level script improvement

### SUB validate_command_line_args ### DOES: perform various sanity + checks on command line argume +nts ############# sub validate_command_line_args { my ($name,$prompt,$configf,$quiet,$outf,$debug,$batchsize,$proto,$ +tacacs,$verbose,$header,$maild +st,$path) = @{ $_[0] }; ... if ( $batchsize > 30 ){ warn("$0:WARNING: More than 25 simultanous connections are NOT + allowed!\nReducing Max_Connec +tions to 25.\n"); $batchsize=25; }elsif ( $batchsize < 0 ){ warn("$0:WARNING: Negative Max_Connections are not permitted, +forking has been disabled.\n") +; $batchsize = 0; } }
[download]

The $batchsize variable is lexically scoped to this subroutine so changing its value will have no effect on anything outside this subroutine.

Comment on Re^5: RFC: beginner level script improvement Select or Download Code

Replies are listed 'Best First'.
Re^6: RFC: beginner level script improvement by georgecarlin (Acolyte) on Sep 30, 2013 at 15:55 UTC
ah yes, thank you for noticing. It's fixed via return to and set in main now. I've transformed all of the code but the expect parts by now but want to complete and throughly test it before posting the version 2. However I'm not entirely sure if what I have in mind is going to work. The expect-interaction is entirely independent on the protocol so I will consolidate both prior subs, but since most expect calls are similar I would like to create abstract subs and pass params to them as well as an exp-handle ref. is this possible? rough example: `sub expect_main { my $exp = new Expect; $exp->configure_stuff; my $FB = expect_do_something(\$exp, \@expectthese, \@sendthese); } sub expect_do_something { my ($exp,$expectthese,$sendthese) = @_; $exp->expect(5, [ qr/$expectthese->[0]/, sub { $exp->send("$sendthese->[0]");}], [ qr/$expectthese->[1]/, sub { $exp->send("$sendthese->[1]");}], ); my $fb = $exp->before(); return $fb; }` [download] Would this work or is it impossible to interact with the expect handle and methods this way? Or is there maybe a better way? Thanks in advance.	[reply] [d/l]

Replies are listed 'Best First'.

Re^6: RFC: beginner level script improvement
by georgecarlin (Acolyte) on Sep 30, 2013 at 15:55 UTC

I've transformed all of the code but the expect parts by now but want to complete and throughly test it before posting the version 2. However I'm not entirely sure if what I have in mind is going to work.

The expect-interaction is entirely independent on the protocol so I will consolidate both prior subs, but since most expect calls are similar I would like to create abstract subs and pass params to them as well as an exp-handle ref. is this possible?

sub expect_main {

    my $exp = new Expect;
    $exp->configure_stuff;
    my $FB = expect_do_something(\$exp, \@expectthese, \@sendthese);

}

sub expect_do_something {
    my ($exp,$expectthese,$sendthese) = @_;
    $exp->expect(5,
        [ qr/$expectthese->[0]/, sub { 
            $exp->send("$sendthese->[0]");}],
        [ qr/$expectthese->[1]/, sub {
            $exp->send("$sendthese->[1]");}],        
    );
    my $fb = $exp->before();
    return $fb;
}
[download]

[reply]
[d/l]