Re: Memory leak in XS code that handles C++ exceptions

Does your unix longjmp() call C++ destructors (some do, see http://msdn.microsoft.com/en-us/library/yz2ez4as%28v=vs.90%29.aspx?

croak is implemented with longjmp. Would you call longjmp from a catch block if this wasnt Perl? The simplest longjmp implementation will make the C++ exception dispatcher leak all of its resources.

WAG, do a goto from the catch block to the parent block (outside of try/catch), then call croak. Or try a finally block.

Comment on Re: Memory leak in XS code that handles C++ exceptions

Replies are listed 'Best First'.
Re^2: Memory leak in XS code that handles C++ exceptions by slower (Acolyte) on Oct 03, 2013 at 14:53 UTC
Thanks bulk88, I wasn't aware of the internal implementation of croak, or longjmp for that matter. I see that longjmp combined with C++ objects can be a Very Bad Thing: No destructors for automatic objects are called. If replacing of longjmp with throw and setjmp with catch would execute a non-trivial destructor for any automatic object, the behavior of such longjmp is undefined. From http://en.cppreference.com/w/c/program/longjmp Your suggestion to croak outside the catch block worked! I actually don't even need a goto; I can just capture the exception message in a string, let the catch block exit normally, then croak with the captured message like so: void Foo::bar() CODE: const char* error = 0; try { THIS->bar(); } catch (const std::runtime_error &e) { error = e.what(); } if (error != 0) { croak(error); }	[reply]

Replies are listed 'Best First'.

Re^2: Memory leak in XS code that handles C++ exceptions
by slower (Acolyte) on Oct 03, 2013 at 14:53 UTC

No destructors for automatic objects are called. If replacing of longjmp with throw and setjmp with catch would execute a non-trivial destructor for any automatic object, the behavior of such longjmp is undefined.

From http://en.cppreference.com/w/c/program/longjmp

void
Foo::bar()
  CODE:
    const char* error = 0;
    try {
      THIS->bar();
    }
    catch (const std::runtime_error &e) {
      error = e.what();
    }

    if (error != 0) {
      croak(error);
    }

[reply]