Re^2: Iterator to parse multiline string with \\n terminator

WRT your edit

What do you think about a return instead of an if? e.g.:

sub fh_iterator {
    my $fh   = shift;
    my $line = $fh->getline();
    return $line unless $line;

    $line .= $fh->getline() while $line =~ m{\\$};

    return $line;
}
[download]

I don't think there's any functional difference, but one may be more readable than the other...

Thanks for your help!

Comment on Re^2: Iterator to parse multiline string with \\n terminator Download Code

Replies are listed 'Best First'.

Re^3: Iterator to parse multiline string with \\n terminator
by tinita (Parson) on Oct 06, 2013 at 12:46 UTC

return $line unless $line;

return $line unless defined $line;

[reply]
[d/l]
[select]

Re^3: Iterator to parse multiline string with \\n terminator
by Athanasius (Archbishop) on Oct 06, 2013 at 16:28 UTC

++tinita for highlighting the important difference between testing for definedness and testing for truth (see perlsyn#Truth-and-Falsehood).

But even with the correction I prefer my version. Readability is in the eye of the programmer, but the first high-level programming subject I took at Uni (in Pascal!) emphasised structured programming, and this has remained with me. I prefer a function to have a single exit point (at the end) where possible. In Perl this is not always optimum, so I’ve had to learn to be flexible. But when — as in this case — the structured version is as straightforward as the non-structured one, I prefer the former. YMMV.

As always in Perl, TMTOWTDI.

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

[reply]