Re^5: how to check if a particular value exist in list of files stored in an array

A few comments:

$field-2 is not a valid variable name, so I have replaced it with $field_2
In order to get your complete output you need to store the full line of data. So I have changed the while statement, see below.
You do not need chomp as you are only looking at the first two fields. When $line is printed later, the newline is desired anyway.
$field2 = $field-2 is an assignment not a comparison. Use eq to compare strings, see below.

foreach my $file_name (@array) {
    open FILE, "$file_name" or die "File not exists";
    while ( my $line = <FILE> ) {
        my ( $field1, $field2 ) = split /\,/, $line;
        if (exists $records{$field1}) {
            $field_2 = $records{$field1};
            if( $field2 eq $field_2 )
            {
                print OUTPUT $line;
            }
        }
    }
}
[download]

Comment on Re^5: how to check if a particular value exist in list of files stored in an array Select or Download Code

Replies are listed 'Best First'.
Re^6: how to check if a particular value exist in list of files stored in an array by Perlseeker_1 (Acolyte) on Oct 30, 2013 at 08:54 UTC
Hi Experts, The code which i used is taking more time to check each file and print the line to output file As each file contains millions of records, taking field1 from the condition file and searching all the files in @filelist, the files may be 1...........100, the size of each file is in GB `foreach my $file_name (@array) { open FILE, "$file_name" or die "File not exists"; while ( my $line = <FILE> ) { my ( $field1, $field2 ) = split /\,/, $line; if (exists $records{$field1}) { $field_2 = $records{$field1}; if( $field2 eq $field_2 ) { print OUTPUT $line; } } } }` [download] Please help on this	[reply] [d/l]
Re^7: how to check if a particular value exist in list of files stored in an array by hdb (Monsignor) on Oct 30, 2013 at 08:59 UTC
I would expect that checking several 100 GBytes takes some time... Update: If you store the information of your condition file already as `"field1,field2" => 1`, ie in the same format that you encounter in your large files you can rewrite it as: `foreach my $file_name (@array) { open FILE, "$file_name" or die "File not exists"; while ( <FILE> ) { print OUTPUT $_ if /^(.?,.?),/ and exists $records{$1}; } }` [download] Maybe this is faster...	[reply] [d/l] [select]
Re^8: how to check if a particular value exist in list of files stored in an array by Perlseeker_1 (Acolyte) on Oct 30, 2013 at 11:04 UTC
Hi Experts, As mentioned in my pervious posts, i have condition-file which contains data as... `condition-file --------------- K 01 J 02 I 03 H 04` [download] i have input files where i have stored all the files in a array called @filelist, which may be file1,fie2,....filen.Each file contains record like... `file1 ------- K,01,data,japan,jung,kcika,Kisjl,01234 J,02,thaja,China,cunk,Jksb,Yjski,23456` [download] i need to take first element from the condition-file and need to check if it exists in all files exist in @filelist for example, i have taken the first element from condition-file, K and will check if this exists in each file in @filelist check in file1, if exists print the line to output text file, check file 2 and do the same till filen i have code which is taking more than 1 hour.Although it works fine, it takes very long time, 30 min to 1 hour. I also tried following Perl script `foreach my $file_name (@array) { open FILE, "$file_name" or die "File not exists"; while ( my $line = <FILE> ) { my ( $field1, $field2 ) = split /\,/, $line; if (exists $records{$field1}) { $field_2 = $records{$field1}; if( $field2 eq $field_2 ) { print OUTPUT $line; } } } }` [download] I was wondering if someone could suggest a solution	[reply] [d/l] [select]
Re^9: how to check if a particular value exist in list of files stored in an array by Corion (Patriarch) on Oct 30, 2013 at 11:12 UTC
Re^9: how to check if a particular value exist in list of files stored in an array by Perlseeker_1 (Acolyte) on Oct 30, 2013 at 17:28 UTC