Using file::find to find dupe dirs

RockE has asked for the wisdom of the Perl Monks concerning the following question:

I am trying to get this to work but it's not only printing out all instances of a duplicate directory but its also printing out a directory that doesn't have any duplicates... Any help to get this thing to work would be appreciated. I'm unable to install any of the other related file:find modules at work so file:find is it.

#!/usr/bin/perl
# dirdupes

use strict;
use warnings;
use File::Find;
#*****************Path Variables**********************
our $testpath = 'C:\\Temp\\';
#******************************************************* 

my %dirs;
find(\&dir_names, $testpath);
my @dup_dirs = grep { $dirs{$_} > 1 } sort keys %dirs;
foreach my $list (@dup_dirs) {
    print "$list\n";
}

sub dir_names
{
    return unless -d;
    return unless /[IPD]\d{8}$/;
    $dirs{$File::Find::name} = 1;
    ++$dirs{$File::Find::name};
}
[download]

Output
c:\Temp\hddzip>perl dirdupes.pl
C:\Temp/Alcohol/P12345678
C:\Temp/hddzip/I12345678
C:\Temp/hddzip/P12345678
C:\Temp/hddzip/P12345679
C:\Temp/hddzip/Test1/P12345678
C:\Temp/hddzip/Test2/P12345678
[download]

There is only one P12345679 directory

**Update** I fiddled around some more and got this to work.

#!/usr/bin/perl
# dirdupes

use strict;
use warnings;
use File::Find;
#*****************Path Variables**********************
our $testpath = 'C:/Temp/';
#******************************************************* 

my %dirs;
find(\&dir_names, $testpath);

foreach my $D (sort keys %dirs) {
    if (@{$dirs{$D}} > 1) {
        print "\nFound duplicate directories\n";
        foreach my $dupes (@{$dirs{$D}}) {
            print "$D - $dupes\n";
        }
    }
}
sub dir_names
{
    return unless -d ;
    return unless /([IPD]\d{8})$/;
    my $P00 = $_; #or $1
    if (not exists($dirs{$P00})) {$dirs{$P00}=[];}
    push @{$dirs{$P00}},$File::Find::dir;
}
[download]

C:\Temp\hddzip>perl dirdupes.pl

Found duplicate directories
I12345678 - C:/Temp/hddzip
I12345678 - C:/Temp/hddzip/Test1

Found duplicate directories
P12345678 - C:/Temp/Alcohol
P12345678 - C:/Temp/hddzip
P12345678 - C:/Temp/hddzip/Test1
P12345678 - C:/Temp/hddzip/Test2

Found duplicate directories
P12345679 - C:/Temp/hddzip
P12345679 - C:/Temp/hddzip/PDF
[download]

Comment on Using file::find to find dupe dirs Select or Download Code

Replies are listed 'Best First'.
Re: Using file::find to find dupe dirs by kcott (Archbishop) on Nov 14, 2013 at 07:36 UTC
G'day RockE, You raised this general issue in: File:Find pattern match question You asked about this specific problem in: Re^8: File:Find pattern match question The same answer that two monks have provided here was already given in: Re^9: File:Find pattern match question Do try to read responses to outstanding questions before reposting the question. If you don't understand an answer: ask. If you feel a new thread is appropriate, provide a link to the original to avoid wasting time with duplication of effort. -- Ken	[reply]
A reply falls below the community's threshold of quality. You may see it by logging in.
Re: Using file::find to find dupe dirs by GrandFather (Saint) on Nov 14, 2013 at 01:46 UTC
`$dirs{$File::Find::name} = 1;` [download] in `sub dir_names` is bogus. The following increment line does all the work required. Update: Oh, and you probably want to compare just the directory name instead of the full path so you probably want to use $_ for the hash key. Actually, even better is to keep a list of full paths by directory name so you can see the full path of all duplicated directories: #!/usr/bin/perl # dirdupes use strict; use warnings; use File::Find; #***************Path Variables****************** our $testpath = 'E:\scratch~~\Lin\App\KuraCloud'; #***************************************************** my %dirs; find(\&dir_names, $testpath); my @dup_dirs = grep {$dirs{$_} > 1} sort keys %dirs; foreach my $name (@dup_dirs) { next if @{$dirs{$name}} == 1; print "$name:\n"; print " $_\n" for @{$dirs{$name}}; } sub dir_names { return if ! -d \|\| ! /[IPD]\d{8}$/; push @{$dirs{$_}}, $File::Find::name; } [download] True laziness is hard work	[reply] [d/l] [select]
Re^2: Using file::find to find dupe dirs by RockE (Novice) on Nov 14, 2013 at 05:41 UTC
Thanks for replying	[reply]
Re: Using file::find to find dupe dirs by boftx (Deacon) on Nov 14, 2013 at 01:50 UTC
Remove the commented line. It is causing every entry in `%dirs.` to always be equal to '2'. `sub dir_names { return unless -d; return unless /[IPD]\d{8}$/; # $dirs{$File::Find::name} = 1; ++$dirs{$File::Find::name}; }` [download] It helps to remember that the primary goal is to drain the swamp even when you are hip-deep in alligators.	[reply] [d/l] [select]