in reply to Re: scandns.pl
in thread scandns.pl

That's stupid. A better, simpler, less logic-assaulting change would be to address the warning message itself, by changing 

my $x;

[download]
to 
my $x=0;

[download]
More to the point, your "fix" completely blows the logic of the code, which attempts to implement the requirement that all four of the octets must be in the range 0..255. Your "fix" would say that an argument of 1.99999.99999.99999 is a valid IP address.

I reckon we are the only monastery ever to have a dungeon stuffed with 16,000 zombies.

Replies are listed 'Best First'.
Re^3: scandns.pl
by taint (Chaplain) on Nov 14, 2013 at 04:57 UTC
    Right you are jdporter.

    Boy, was I stupid! It would have killed me to take the time to evaluate it. Rather than simply stripping off the offender.

    I'll take more time, before pressing the "create" button, in the future.

    Sorry for the bother, and thanks for calling me on it, jdporter.

    --Chris

    #!/usr/bin/perl -Tw
use Perl::Always or die;
my $perl_version = (5.12.5);
print $perl_version;
[reply]
Re^3: scandns.pl
by taint (Chaplain) on Nov 14, 2013 at 06:00 UTC
    The eval: 
    $x++ if(($_>=0)&&($_<=255));

    [download]
    as I read it, is:
    if the input ($x), is at least 0, and no greater than 255
    $x is legitimate, so return $x
    So as I see it. There is nothing afoul with my proposed solution.

    :)

    --Chris

    #!/usr/bin/perl -Tw
use Perl::Always or die;
my $perl_version = (5.12.5);
print $perl_version;
[reply]
[d/l]
      as I read it...

      You're reading it wrong.

      $x is counting the number of valid octets. The number of valid octets should be 4, not simply >0. It's fine to return 4 rather than 'true', but it is not fine to return 1 or 2 or 3. The number of the counting shall be 4.

      I reckon we are the only monastery ever to have a dungeon stuffed with 16,000 zombies.
[reply]
[reply]
Re^3: scandns.pl
by taint (Chaplain) on Nov 14, 2013 at 05:29 UTC
    Greetings jdporter.

    So is you're assignment.

    I take back most of my 1st reply to you.

    If choosing you're assignment. CDIR masks will be rejected: 

    % ./scandns.pl 209.197.123.153/29
209.197.123.153 is an invalid address.
%

    [download]
    Using my assignment (correct, or incorrect): 
    % ./scandns.pl 209.197.123.153/29
209.197.123.152 => renku.org => 4.79.43.173 
209.197.123.153 => perlmonks.pair.com 
209.197.123.154 => taidsaccount.com 
209.197.123.155 => murphyworld.com => 208.91.197.132 
209.197.123.156 => beetz.at 
209.197.123.157 => best-kids-bedding-prices-online.com => best-kids-be
+dding-prices-online.com has no A record
209.197.123.158 => lowest-prices-for-kids-bedding.com => lowest-prices
+-for-kids-bedding.com has no A record
209.197.123.159 => no PTR record
%

    [download]
    Not to sound too much the smart a$$. But before ridiculing someone for trying to help. Perhaps it best to test your own solution first?

    Best wishes.

    --Chris

    #!/usr/bin/perl -Tw
use Perl::Always or die;
my $perl_version = (5.12.5);
print $perl_version;
[reply]
[d/l]
[select]

      I don't know, I think maybe you've made other changes to the code? Because when I run it with that exact argument — 209.197.123.153/29 — I get a result indicating that the IP address is valid.

      I reckon we are the only monastery ever to have a dungeon stuffed with 16,000 zombies.
[reply]
[d/l]
        Greetings, jdporter.

        I just now copied the source from this page. Then only removed the
        ($x==4)
        from the offending line, and replaced it with your proposed solution
        ($x=0)
        then ran it;

        % ./scandns.pl 209.197.123.153/29
209.197.123.153 is an invalid address
%

        [download]
        I have no idea. The only possible difference(s) I can imagine, would be

           * differing OS's
           * differing versions of: IO::Socket or Net::Netmask
           * differing versions of Perl itself

        Sincerely confused.

        Best wishes.

        --Chris

        #!/usr/bin/perl -Tw
use Perl::Always or die;
my $perl_version = (5.12.5);
print $perl_version;
[reply]
[d/l]

In Section Code Catacombs