in reply to Adding an new element after every 5th element in array

You should show what code you used in your splice implementation, because it certainly could work, assuming you're using it right.

If I were doing this, and memory weren't a constraint, I would make a new array, and then replace the old one with the new one once done. The reason is that every time you insert into the middle of an array, all elements that follow must be shifted to the right one step, which is relatively expensive. Here's an example of how I would do it:

@array = do { my @array2; foreach ( @array ) { push @array2, $_; push @array2, "new_element" if $_ eq 'remove'; } @array2; };

Or, avoiding the temporary @array2:

@array = map { $_, ( $_ eq 'remove' ? "new element" : () ) } @array;

For additional efficiency, you might do it this way instead:

@array = map { $array[$_], ( ($_+1) % 3 == 0 ? "new element" : + () ) } 0 .. $#array;

The latter avoids a full string comparison on each iteration, by keeping track of index number rather than element contents.


Dave

Replies are listed 'Best First'.
Re^2: Adding an new element after every 5th element in array
by dvinay (Acolyte) on Nov 26, 2013 at 19:34 UTC

    hi dave,

    Thanks for the solution, but i need one more change in requirement, instead of adding the new element after "remove", i need to add the new element say after every multiples of 10th set, i.e. 10th set, 20th set,30th set and 40th set.

    How it can be achieved...?

      in my final example it is as easy as changing the number 3 to some other interval. Take the time to understand the solutions we provide and you will understand how to modify them to your needs.


      Dave

        Yeah Dave i got the solution, and have made changes for the count interval,when i posted the reply i didnt observe the last solution which you had made, then after that i saw it

        Thanks for the solution