varalaxmibbnl:

When you have a problem like this, you should add some print statements to show your variables, so you can verify that they hold what you're expecting. In this case, try adding $. to your existing print statement, like this:

print "$., $line"
[download]

When you do so, your output is:

10
15: 1
15: hw
15: r
15: u
15: hi
15: 2
15: hw
15: r
15: u
15: hi
15: 3
15: hw
15: r
15: u
[download]

So you can see that the line number is 15 for every iteration through your for loop. Why is that? It turns out that when you use foreach it wants a list in the parenthesis, so it reads the entire file at once. It then gives you one line at a time.

Generally when processing a file and want to do it one line at a time, we do it like:

while (my $line = <MYFILE>) {
   ... code in loop ...
}
[download]

There are some other issues in your code, but I'll let your instructor clarify that.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

What do you think this code actually does? Please stop and think about that for a minute. Some hints:

• use strict; use warnings; Use strict and warnings (then fix the errors), Basic debugging checklist
• use open properly
• http://learn.perl.org, Tutorials, Modern Perl.

use strict; use warnings; Use strict and warnings (then fix the errors)

Seriously? Which errors? How does adding that text to the start of the OP's program help him solve his problem?

use open properly

As opposed to opening the files he wants to read, as he does already?

*sigh*

"Seriously? Which errors? How does adding that text to the start of the OP's program help him solve his problem?"

The errors generated from running the code presented simply when adding use strict; use warnings;. Does the reasoning in Use strict and warnings not ring true to you?

"As opposed to opening the files he wants to read, as he does already?"

Without returning $! on error, I'd advise getting into the habit of using 3 argument open, safer, cleaner.

From their previous posts they do these things in some examples, and not in others, the coding style is different suggesting they're copying and pasting code from elsewhere, don't understand what it's doing and post 'problems' here.

If the goal is to encourage someone who doesn't seem to understand the basics of the language to actually learn the language, how best to avoid or report errors the advice you question still seems sound to me.