Re^2: Can you make this code shorter and/or quicker as well?

Replies are listed 'Best First'.
Re^3: Can you make this code shorter and/or quicker as well? by kcott (Archbishop) on Feb 25, 2014 at 10:20 UTC
"Excellent solution!" Thankyou. "But it still needs a `tr/\r//d` in there somewhere :)" I'm not sure that it does. If the input file was created on an MSWin system and then subsequently processed on a nix system, then some additional handling of line-endings may be appropriate. The four instances of "`s/[\r]//g`"* suggest multiple embedded carriage-returns; although, that might just be poorly coded. The single `chomp` doesn't add a lot of clarity either. If the OP can show where carriage-returns are embedded, I can certainly add a transliteration like you suggest. -- Ken	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: Can you make this code shorter and/or quicker as well?
by kcott (Archbishop) on Feb 25, 2014 at 10:20 UTC

"Excellent solution!"

Thankyou.

"But it still needs a tr/\r//d in there somewhere :)"

I'm not sure that it does. If the input file was created on an MSWin system and then subsequently processed on a *nix system, then some additional handling of line-endings may be appropriate.

The four instances of "s/[\r]//g" suggest multiple embedded carriage-returns; although, that might just be poorly coded. The single chomp doesn't add a lot of clarity either.

If the OP can show where carriage-returns are embedded, I can certainly add a transliteration like you suggest.

-- Ken

[reply]
[d/l]
[select]