In your Option 2, try my @files = glob("/opt/tmp/*");, otherwise you'll only get files that include a dot in the name.

In your Option 3, the opendir line should be: opendir(DIR, "/opt/tmp/") or die "Cannot open dir"; (misplaced closing paren). Also, the grep causes @files to only include "text" files (see documentation of -T in -X), is that what you want?

No, my directory contains xml files. I will take a look at the documentation.

Thanks for the help

Depending on the encoding of your XML files, the -T test may or may not recognize them as "text" files. From -X:

The -T and -B switches work as follows. The first block or so of the file is examined for odd characters such as strange control codes or characters with the high bit set. If too many strange characters (>30%) are found, it's a -B file; otherwise it's a -T file. Also, any file containing a zero byte in the first block is considered a binary file.

use File::Find;

find({wanted => sub {-f and print "file = $_\n"},follow => 1},'.');
[download]

1st recommandation should be File::Find. In your case

Are you sure about that? Because that doesn't have /opt/tmp or @files

My first recommendation is always File::Find::Rule

use File::Find::Rule qw/ rule find /;
my @files = find( file => maxdepth => 1, ascii => in => '/opt/tmp' );
[download]

O.K., you'd have to change '.' from my snippet to '/opt' or '/opt/tmp' or $dir to work it on other than current dir. Whether you use File::Find or File::Find::Rule is more a matter of taste. The maintainer of the module describes it as a is a friendlier interface to File::Find :-).

Greetings,
Janek Schleicher

... already does what you intend...

All three of the OP's examples don't descend into subdirs, this one does. Also, this code doesn't show which subdir the file was found in, so you'd probably want something like this instead:

find({wanted => sub {-f and print "file = $File::Find::name\n"},follow => 1},"/opt/tmp");

You wrote:

opendir(DIR, "/opt/tmp/" or die "Cannot open dir");

whereas what you probably meant was:

Better would be:

Perhaps better still would be DirHandle but YMMV.

Could this be a permissions issue?

Try changing your error message on the opendir to "Cannot open dir: $!" to see the details of what went wrong.

Try prefixing your code with the line: warn "Can't read /opt/tmp\n" unless -r "/opt/tmp";

Also, in general, you should use warnings; use strict; at the top of your scripts if you aren't already.

I tend to favour using glob and a pattern. However, if it's not printing anything, means that the 'glob' hasn't found any matching files. Try running running an 'ls' or an 'echo' of that precise thing. Alternatively, try pruning down '*.*' - is it _really_ 'any file with a dot in it' that you want to find, or something more specific? Try your glob on "/opt/tmp/*" for example, and see what results you get.

use strict;
use warnings;
use File::Find;

find(&dostuff, '/opt/tmp');
sub dostuff {
  # $File::Find::name = /opt/tmp/foo
  # $_ = foo
  # $File::Find::dir = /opt/tmp
}
[download]

Try

#!/usr/bin/perl --
use strict; use warnings;
use Path::Tiny qw/ path /;
use Data::Dump qw/ dd /;
my @files = path( "/opt/temp" )->children;
dd( \@files );
@files = grep { =T $_ } @files;
dd( \@files );
__END__
[download]

Path::Tiny will throw an exception if permission is denied, just like the soldiers at Fort Knox :)

s/=T/-T/
[download]

لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ

glob comes with a few caveats, such as: it doesn't include files beginning with a dot unless you specifically tell it to, e.g. <* .*>. Also, it uses certain metacharacters which one should be aware of (\*?~[]{}). See also File::Glob.

If you want to list all of the files in a single directory without subdirectories, opendir+readdir is fine for that. no_upwards() from File::Spec is helpful in getting rid of the . and .. directory entries. Otherwise, if you want to recurse into subdirectories, other monks have already shown some examples using File::Find and File::Find::Rule.

Hi,

I tried using :

@files = glob("/opt/tmp/*");
[download]

i don't get any output. I checked the folder permissions and i have : drwxrwxwx

I also tried:

opendir(DIR, "/opt/tmp/") or die "Cannot open dir";

@files = grep {"/opt/tmp/*.xml"} readdir DIR;
[download]

I get an error : "Cannot open dir". However, like i mentioned before the folder as all permissions

I tried using Tiny, but i got an error saying: "can't locate Path/Tiny.pm in @INC

Im going to try and use find next

As you have already been advised in Re: Perl List files in directory, please make your error messages more informative:

opendir(DIR, "/opt/tmp/") or die "Cannot open dir: $!";
[download]

This will tell you the immediate cause of the problem.

I did that, i only get: "Cannot open dir: No such file or directory at ./script.pl line 28".

which doesn't had much.

I managed to get it working with open dir, i placed the files under a new directory.

the problem is that now I'm getting everything, even sub-directories and i only want the xml files

opendir(dir, new_dir) or die "Cannot open dir : $!";

@files = grep {"*.xml"} readdir DIR;
[download]

can someone tell me what i'm missing?

I found the answer:

@files = grep {-f "$dir/$_" && m/.xml/} readdir DIR;
[download]

Thanks for the help people

I'd suggest a small tweak to that:

@files = grep {-f "$dir/$_" && /\.xml$/i} readdir DIR;

Because otherwise the regular expression would have matched a file named "fooxml.bar" as well. Also, this now matches the extension case-insensitively, just in case.