Re: How can I expand my substring?

use strict;
use warnings;

my $maxLen = 20;
my @tests = (
    ['N' . ('-' x ($maxLen + 20)) . 'B', 'N' . ('-' x 20) . ('B' x ($m
+axLen + 1))],
    ['-B' . ('-' x ($maxLen + 20)), '-B' . ('B' x $maxLen) . ('-' x 20
+)],
    ['-N-N--B--N', '-N-NBBBBBN'],
    ['N-N-B-', 'N-NBBB'],
    ['-B-N-B-N-B-N', '-BBNBBBNBBBN'],
    ['-B-N', '-BBN'],
    ['-B-', '-BB'],
    ['B-', 'BB'],
);

for my $test (@tests) {
    my ($org, $ref) = @$test;
    my $str = $org;
    
    $str =~ s/((?=N-+)(?:N)(?:-*?))(-{1,$maxLen}B)/$1 . ('B' x length 
+$2)/eg;
    $str =~ s/(B-{1,$maxLen})(?=-*(N|$))/'B' x length $1/eg;
    next if $str eq $ref;

    print "Couldn't handle: '$org'\n";
    print "       Expected: '$ref'\n";
    print "            Got: '$str'\n"
}
[download]

which generates no output indicating all is well.

The two regex sustitutions:

    $str =~ s/((?=N-+)(?:N)(?:-*?))(-{1,$maxLen}B)/$1 . ('B' x length 
+$2)/eg;
    $str =~ s/(B-{1,$maxLen})(?=-*(N|$))/'B' x length $1/eg;
[download]

do the work. The rest is test code. Change maxLen to the maximum number of characters to replace.

Perl is the programming world's equivalent of English

Comment on Re: How can I expand my substring? Select or Download Code

Replies are listed 'Best First'.
Re^2: How can I expand my substring? by Anonymous Monk on Jul 23, 2014 at 14:39 UTC
Thank you very much for this! I tried it and it works, but I think there is a problem if the string does not contain NNNNN but only --- and BBBB. I tried this: $initial_string = '--------------------------------------------------- +--------------------------------------------------------------------- +--------------------------------------------------------------------- +------------------------------------------------------------------BBB +BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB +BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB +BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB +BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB-----------------'; print $initial_string."\n"; $maxLen = 200; $initial_string =~ s/((?=N-+)(?:N)(?:-?))(-{1,$maxLen}B)/$1 . ('B' x +length $2)/eg; $initial_string =~ s/(B-{1,$maxLen})(?=-(N\|$))/'B' x length $1/eg; print $initial_string."\n"; [download] and it only expanded the BBBB substring to the right of it, not to the left.	[reply] [d/l]
Re^3: How can I expand my substring? by GrandFather (Saint) on Jul 23, 2014 at 20:58 UTC
Your "specification" says: "... until it either reaches the end of the string on its right (NOT on its left), or until it reaches an N ..." so that is what I implemented. As a general the better you specify a task the easier it becomes to implement. A good approach in this sort of case is to provide tests for each case you are interested in then the tests become part of the specification and also allow you to validate the behaviour of the code. Also note that I already gave you a test framework so the appropriate way to check that case is to provide the start string and the expected string as I did for the other test cases. That allows us to see what you expected to happen and how that differs from what did happen. It also allows you to play with the substitution code and check that you haven't broken test cases that were previously working. This technique of writing tests first then writing the code so they pass is a very powerful way of developing software and, as can be seen from this example, works even for trivial code. Perl is the programming world's equivalent of English	[reply]