1 you don't return anything from the function. 2 shift needs an array; $hash{} needs a key; obviously not going to work