Re^8: search and replace strings in different files in a directory (Path::Tiny)

Here’s some feedback on your annotations:

use Data::Dump qw/ dd /;
# Creates a shortcut for calling Data::Dumper, writing dd is enough to
+ call module
[download]

Say rather, writing dd is now enough to call Data::Dump::dd. But actually qw/ dd / is not needed here, because the Data::Dump module exports dd by default.

Main( @ARGV );
# main function, takes every file (as an argument) that is passed to @
+ARGV, might be command line or files
#that are read in
[download]

Correct, but note that in Perl, unlike in C, you don’t need a main function. (I assume that by “command line” you mean command line options.)

exit( 0 );
#not really a clue, maybe main exits if no arguments are passed to it
[download]

No, exit terminates the script and returns its argument to the shell. By convention, an exit value of zero means “success: the script terminated without errors.”

    dd( -argv, \@ARGV );
#calls Data::Dumper via reference => possibly to print which files are
+ being passed as arguments (control function)
[download]

No, dd is a Data::Dump function; Data::Dumper is a different module.

    Sky(6);
#not really a clue => Does that mean that the sub stops after six runs
[download]

No, it’s just another call to sub Sky with the literal 6 passed as an argument instead of the variable $ar.

    my( $ra ) = @_;
    # variable for the argument(s) passed to the sub, @_ accepts every
+ argument passed to sub, i.e. the files passed to main
[download]

Yes, but note that only the first of these arguments is being copied to the scalar variable $ra. (All the arguments passed to the sub remain in the array @_.)

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

Comment on Re^8: search and replace strings in different files in a directory (Path::Tiny) Select or Download Code

Replies are listed 'Best First'.

Re^9: search and replace strings in different files in a directory (Path::Tiny)
by Anonymous Monk on Aug 28, 2014 at 08:58 UTC

But actually qw/ dd / is not needed here, because the Data::Dump module exports dd by default.

While technically its "not needed", it sure does document rather well where dd comes from :) so its there for documentation

[reply]

Re^9: search and replace strings in different files in a directory (Path::Tiny)
by PitifulProgrammer (Acolyte) on Aug 28, 2014 at 14:03 UTC

Dear Athanasius,

Thank you for going through my comments and providing feedback. I am quite happy that I was not completely wrong about all lines.

However some questions remain:

Why was the subroutine called with 6 passed as an argument. Was this just for demonstrating that not only strings but also numbers can be passed to a sub?.

Could you please clarify why only the first argument $ra is passed an the others remain in the array? Does that mean that arguments to a sub are passed in some kind of for loop?

my( $ra ) = @_;
    # variable for the argument(s) passed to the sub, @_ accepts every
+ argument passed to sub, i.e. the files passed to main
[download]

Looking forward to your feedback. Will work on the inital code and try to use more subroutines.

Thanks a mil for your support

Kind regards

[reply]
[d/l]

Re^10: search and replace strings in different files in a directory (Path::Tiny)

by Athanasius (Archbishop) on Aug 28, 2014 at 14:59 UTC

Hello PitifulProgrammer,

Why was the subroutine called with 6 passed as an argument. Was this just for demonstrating that not only strings but also numbers can be passed to a sub?

Maybe, I don’t know, I didn’t write the code. ;-)

Could you please clarify why only the first argument $ra is passed an the others remain in the array? Does that mean that arguments to a sub are passed in some kind of for loop?

No, no, no! Perl is not like C, where arguments are passed by value (i.e., as local copies). In Perl, arguments are passed by reference. Specifically, the arguments passed into a subroutine are available within that subroutine in the special array variable @_ (also called @ARG), which contains aliases to the originals.

What this means is that if you call foo($bar, $baz), then within that call to sub foo the variable $_[0], which is the first element of the array @_, is an alias for $bar, and likewise $_[1] is an alias for $baz. So if you change $_[0] within the subroutine, when you return from the subroutine you find that $bar has changed too.

Sometimes this is what you want, but mostly it isn’t. So the usual practice is to make local copies of the arguments before using them. These local copies are not aliases, so changing the local copies has no effect on the originals. There are two ways of creating the local copies:

Within a sub, when shift is used without an explicit argument it automatically shifts @_. For example,
```
sub foo
{
    my $x = shift;
    my $y = shift;
    ...
[download]
```
This removes the first two elements from @_ and makes copies of them in $x and $y, respectively.
Simple assignment:
```
sub foo
{
    my ($x, $y) = @_;
    ...
[download]
```
This makes local copies of the first two elements of @_, but @_ itself remains unchanged.

Please see the entry for @_ in perlvar, and study perlsub, especially the third paragraph of the “DESCRIPTION” section.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

[reply]
[d/l]
[select]

Re^10: search and replace strings in different files in a directory

by Anonymous Monk on Aug 28, 2014 at 23:22 UTC

I'd like to thank Athanasius for picking up the slack :)

Why was the subroutine called with 6 passed as an argument. Was this just for demonstrating that not only strings but also numbers can be passed to a sub?.

:) To demonstrates that arguments can be passed and they end up in @_ ... so you can lookup @_ in perlvar and read about it :)

Its also so you can resolve the issue you had in Re^2: search and replace strings in different files in a directory (Path::Tiny), something like

Read more... (329 Bytes)

and this is very hard to read and maintain, but folks still do it and often struggle debugging this stuff; Main/exit combination is much easier on the brain :)

You can read more about this Main/exit style convention /program template at (tye)Re: Stupid question (and see one discussion of that template at Re^2: RFC: Creating unicursal stars

If you've got more questions, I'll be back :)

[reply]
[d/l]
[select]

Re^11: search and replace strings in different files in a directory

by PitifulProgrammer (Acolyte) on Sep 01, 2014 at 12:08 UTC

Dear Monnks,

I am getting the strange feeling that my undertaking of writing a "simple" script turns out to be a much larger project than I had anticipated.

It is a bit frustrating, but we would not be humans if we could not learn from mistakes. Anyway, you kindly offered your help in your last reply and I think I need it (again), since I cannot figure out the current error messages I have been getting

First message is Cygwin-related (not sure if this is the right place, should I open a new post?).

What I can figure out is that Cygwin won't install the module, but I have not idea why, since any other installation of perl modules on this machine worked like a charm.

NE
Configuring S/SM/SMUELLER/PathTools-3.47.tar.gz with Makefile.PL
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Cwd
Writing MYMETA.yml and MYMETA.json
  SMUELLER/PathTools-3.47.tar.gz
  /usr/bin/perl Makefile.PL -- OK
Running make for S/SM/SMUELLER/PathTools-3.47.tar.gz
cp lib/File/Spec/OS2.pm blib/lib/File/Spec/OS2.pm
cp lib/File/Spec/Mac.pm blib/lib/File/Spec/Mac.pm
cp lib/File/Spec/VMS.pm blib/lib/File/Spec/VMS.pm
cp lib/File/Spec/Functions.pm blib/lib/File/Spec/Functions.pm
cp lib/File/Spec/Epoc.pm blib/lib/File/Spec/Epoc.pm
cp lib/File/Spec/Cygwin.pm blib/lib/File/Spec/Cygwin.pm
cp lib/File/Spec.pm blib/lib/File/Spec.pm
cp Cwd.pm blib/lib/Cwd.pm
cp lib/File/Spec/Unix.pm blib/lib/File/Spec/Unix.pm
cp lib/File/Spec/Win32.pm blib/lib/File/Spec/Win32.pm
Running Mkbootstrap for Cwd ()
chmod 644 Cwd.bs
/usr/bin/perl.exe /usr/lib/perl5/5.14/ExtUtils/xsubpp  -typemap /usr/l
+ib/perl5/5.14/ExtUtils/typemap  Cwd.xs > Cwd.xsc && mv Cwd.xsc Cwd.c
gcc-4 -c   -DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -g -fno-strict-ali
+asing -pipe -fstack-protector -DUSEIMPORTLIB -O3   -DVERSION=\"3.47\"
+ -DXS_VERSION=\"3.47\"  "-I/usr/lib/perl5/5.14/i686-cygwin-threads-64
+int/CORE"  -DDOUBLE_SLASHES_SPECIAL=0 Cwd.c
/bin/sh: gcc-4: Kommando nicht gefunden.
Makefile:367: recipe for target 'Cwd.o' failed
make: *** [Cwd.o] Error 127
  SMUELLER/PathTools-3.47.tar.gz
  make -- NOT OK
Failed during this command:
 SMUELLER/PathTools-3.47.tar.gz               : make NO

cpan[2]>
[download]

I switched to my DOS cmd and thought this would work out, however, when running the script, I got this error message


c:\dev>perl script.pl
Wide character in die at C:/strawberry/perl/site/lib/Path/Tiny.pm line
+ 1492.
Error opendir on '�&#9559;&#9488;Z:/../file.xml': Invalid argument at 
+script.pl line 57.
[download]

line 57 in the script would be the line with ->children qr/.../(*.xml), which retrieves the xml files:

sub RetrieveAndBackupXML {
#~     my( $directory ) = @_; ## same as shift @_ ##  same as shift
    my $directory = shift;
    my $date      = POSIX::strftime( '%Y-%m-%d', localtime ); #sets cu
+rrent date and time to be added to backup file
    my $bak       = "$date.bak"; #date added to the .bak file
    my @xml_files = path( $directory )->children( qr/\.xml$/ );
    for my $file ( @xml_files ) {
        Replace( $file, "$file-$bak" ); #sub Replace using it's 2 para
+meters as defined below
    }
}
[download]

Those xml-files are unicode, so I am wondering why I am getting this wide character message again

Would be grand if you guys could assist me in this matter, if you need more information about the code or my system let me know.

Kind regards

[reply]
[d/l]
[select]

Re^12: search and replace strings in different files in a directory

by Corion (Patriarch) on Sep 01, 2014 at 12:11 UTC

Re^13: search and replace strings in different files in a directory

by PitifulProgrammer (Acolyte) on Sep 01, 2014 at 12:28 UTC

Some notes below your chosen depth have not been shown here

Re^12: search and replace strings in different files in a directory

by choroba (Cardinal) on Sep 01, 2014 at 12:18 UTC

Re^13: search and replace strings in different files in a directory