in reply to Re^4: Turn off FATAL warnings in 3rd party module
in thread Turn off FATAL warnings in 3rd party module

stevieb that's cool! Will the "pull request" alert the author about the issue and possibly initiate a fix from him?

  • Comment on Re^5: Turn off FATAL warnings in 3rd party module

Replies are listed 'Best First'.
Re^6: Turn off FATAL warnings in 3rd party module
by stevieb (Canon) on Jun 03, 2019 at 16:32 UTC

    Yep, it most certainly will :)

      Tree::Fast has the same problems. Since you prepare such a nice test file and I can't really copy-paste it for a PR of my own, would you like to do the same for that? Thanks.

        Hey bliako, if you look closely at the PR, you'll see that I've fixed the issue in all the Tree:: sub-modules already.

        R

        Essentially, Tree::Fast, Tree::Binary2 and Tree::DeepClone are all based out of the parent Tree distribution, and I've patched all of those along with the root module :)

        If the PR is accepted, merged and a new version of the distribution is uploaded to the CPAN, then all of the above mentioned children will be "fixed" at the same time.

        If you install from my updated repo, all of them should be fixed simultaneously (I'll update the test file later so all are included).