in reply to Valid code?

Hi, looks wrong to me too.

I guess you are trying to generate an SQL snippet for MySQL. Assuming $newdateadded is a number, not a date,

(TO_DAYS(dateadded)-TO_DAYS(Now())>=-$newdateadded)
or ...
( N # number of days from 0 for a date presumably in the past - M # number of days from 0 to now ) # will yield a negative number >= -O # some number of days, but negative
...
so your SQL will be something like:
( ( TO_DAYS(dateadded) - TO_DAYS(Now()) ) >= -42 )
and for values like the first of the month and today, that would be parsed as:
( ( TO_DAYS("2020-03-01") - TO_DAYS("2020-03-17") ) >= -42 )
... or:
(737850 - 737866) >= -42)
... which evaluates to true, so whatever runs the query captured in the $no_days variable will know that.

This may be what you want, but I still say it looks wrong, because of the convoluted logic in the comparison, and because of the variable naming.

Hope this helps!


The way forward always starts with a minimal test.

Replies are listed 'Best First'.
Re^2: Valid code?
by afoken (Chancellor) on Mar 18, 2020 at 09:58 UTC
    I guess you are trying to generate an SQL snippet for MySQL.

    If that is true, htmanning is probably creating an SQL injection vulnerability here. As always, placeholders should be used instead. Not only does that prevent SQL injections, but it also allows caching and reuse of prepared SQL statements.

    Alexander

    --
    Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)