Re^3: sendmail working for me but not another

So you are saying it should look like this?

Yes, what you showed is correct. Note it's generally better to use heredocs instead of a multiline qq, so e.g.

my $email_message = <<"ENDMAIL";
To: $recipient
Subject: Adoption Application
...
ENDMAIL
[download]

My host is telling me i'm not allowed to look at the email logs, I've asked them what I can access and i'm waiting to hear.

You could write out your data to a logfile on your account, in case something with the emails doesn't work out.

I know the code is horrible but i'm learning.

If this were a legacy script, ok, but if this a new script, then you'd be much better off learning something more modern. I've been doing a lot with Mojolicious recently, and I think it's pretty great. See Mojolicious::Guides::Tutorial for getting started. Otherwise, at the very least what this script needs is to Use strict and warnings! See also UP-TO-DATE Comparison of CGI Alternatives.

And with that many variables, it'd be much better to store them in a data structure like a hash. Then you could do things like loop over it so you don't have to repeat the regex a bunch of times. (Also, note you don't seem to be doing anything with the yardtypeother field.)

Also, you should check if the host has Email::Sender::Simple installed, that should be much better and easier to use than shelling out to sendmail.

Comment on Re^3: sendmail working for me but not another Select or Download Code

Replies are listed 'Best First'.
Re^4: sendmail working for me but not another by kickingchicken (Initiate) on May 26, 2020 at 03:52 UTC
See Mojolicious::Guides::Tutorial for getting started. Thanks, I will definitely check mojo out. My script is legacy, at least this is a good opportunity to learn perl, should have long time ago. I will up date my script with heredocs. I was using strict and warnings but I keep getting blank page or 404. I've been working on finding out what is causing it, but havn't been able to. I'm using use CGI::Carp qw(fatalsToBrowser warningsToBrowser); When I get rid of strict it will process with warnings, 3 variables were not initialized properly. but with strict it is just a blank screen. There is a lot of information here, i'm going to go through what everyone has given me and change my code. If I could get some kind of log, it would help but i'm still waiting on my host..	[reply]
Re^5: sendmail working for me but not another by haukex (Archbishop) on May 26, 2020 at 07:24 UTC
I was using strict and warnings but I keep getting blank page or 404. I've been working on finding out what is causing it, but havn't been able to. When you add strict, you need to declare your variables with my, as in `my $fstname = substr param ('first'), 0, 40;` (see Use strict and warnings). Also, note that CGI scripts can be run at the command line, as in `perl script.cgi 'first=John&last=Doe&...'`, that way you'll see any error messages the script may be giving you (you might want to disable the email sending while testing, of course). If I could get some kind of log, it would help but i'm still waiting on my host. Yes, getting access to the server logs would be helpful (see also CGI Help Guide and Troubleshooting Perl CGI scripts). With my suggestion I meant that you could add code to your script that writes the data you've received to a log file as well (because POST data won't be in the server logs anyway), that way you still have a backup of the data in case someone submits the form and the email isn't sent out. (A database would be even better, but let's take it one step at a time `:-)` )	[reply] [d/l] [select]