in reply to Critique requested for module code - QuickMemo+ reader

Hi,

Quick observation: I don't think I would return a reference to a string from extract_json_from_lqm -- it complicates the flow down the chain (having to dereference a ref to a scalar). Just return and pass around the string.

Hope this helps!


The way forward always starts with a minimal test.

Replies are listed 'Best First'.
Re^2: Critique requested for module code - QuickMemo+ reader
by Lotus1 (Vicar) on Jan 24, 2021 at 18:31 UTC

    Thanks this helps. I will get rid of the ref for the string. My original module had a function to convert memos to Simplenote format but I decided to simplify down to the bare bones for my first attempt.

[reply]

In Section Seekers of Perl Wisdom