Re: Re: using loop/array to write files

Hi! Thanks for all the replies. I have taken some advice and tried to fix up the script, but I still can't use the "use strict;" line, I get an error.

Also, when I execute the script, then try to open the foler in ws_ftp, it hangs and I have to hit the "Refresh" button in ws_ftp. Then the folder opens and the files are displayed. I am thinking that maybe the $adfile is not being closed?

Here is the new code:

#!/usr/bin/perl

#use strict;   can't use this, I get an error...

my $adfile = '/home/ebrae2/adskingston-www/cgi-bin/ebrae/data/ads.data
+';
my $hits_dir = '/home/ebrae2/adskingston-www/cgi-bin/ebrae/hits/';

$os = $^O;

open(FILE, $adfile) || die "Can't open $adfile";

while ($line = <FILE>) {
  chomp $line;
  
  my @counter_file = split(/\|/,$line);
    
  open (HITS_FILE, ">$hits_dir/$counter_file[0].txt") || die "Can't cr
+eate file";
      ("$hits_dir/$counter_file[0].txt");
    print HITS_FILE "0";
    close (HITS_FILE);
  
if ($os eq "unix") { chmod 0666, "$hits_dir/$counter_file[0].txt"; }
    
  }
  
  close(FILE);
  
  if ($os eq "unix") { chmod 0666, "$adfile"; }
  
  print "Content-type: text/html\n\n";
  
  print "<BR><CENTER>";
  print "<form><input type=button value=\"Success!\" onClick=\"locatio
+n.href('http://www.adskingston.com')\"></FORM>";
[download]

Can anyone see from looking at this code, what I am doing wrong? Thanks!

Comment on Re: Re: using loop/array to write files Download Code

Replies are listed 'Best First'.
Re: Re: Re: using loop/array to write files by ginocapelli (Acolyte) on Sep 10, 2001 at 04:51 UTC
Here is my new code: #!/usr/bin/perl use CGI::Carp qw(fatalsToBrowser); use strict; my $adfile = '/home/ebrae2/adskingston-www/cgi-bin/ebrae/data/ads.data +'; my $hits_dir = '/home/ebrae2/adskingston-www/cgi-bin/ebrae/hits/'; my $lines; my $counter_file; open(FILE, $adfile) \|\| die "Can't open $adfile"; while ($line = <FILE>) { chomp $line; my @counter_file = split(/\\|/,$line); open (HITS_FILE, ">$hits_dir/$counter_file[0].txt") \|\| die "Can't cr +eate file"; ("$hits_dir/$counter_file[0].txt"); print HITS_FILE "0"; close (HITS_FILE); chmod 0666, "$hits_dir/$counter_file[0].txt"; } close(FILE); chmod 0666, "$adfile"; print "Content-type: text/html\n\n"; print "<BR><CENTER>"; print "<form><input type=button value=\"Success!\" onClick=\"locatio +n.href('http://www.adskingston.com')\"></FORM>"; [download] and it still doesn't work...	[reply] [d/l]

Replies are listed 'Best First'.

Re: Re: Re: using loop/array to write files
by ginocapelli (Acolyte) on Sep 10, 2001 at 04:51 UTC

#!/usr/bin/perl

use CGI::Carp qw(fatalsToBrowser);

use strict;

my $adfile = '/home/ebrae2/adskingston-www/cgi-bin/ebrae/data/ads.data
+';
my $hits_dir = '/home/ebrae2/adskingston-www/cgi-bin/ebrae/hits/';
my $lines;
my $counter_file;

open(FILE, $adfile) || die "Can't open $adfile";

while ($line = <FILE>) {
  chomp $line;
  
  my @counter_file = split(/\|/,$line);
    
  open (HITS_FILE, ">$hits_dir/$counter_file[0].txt") || die "Can't cr
+eate file";
      ("$hits_dir/$counter_file[0].txt");
    print HITS_FILE "0";
    close (HITS_FILE);
  
  chmod 0666, "$hits_dir/$counter_file[0].txt";
    
  }
  
  close(FILE);
  
  chmod 0666, "$adfile";
  
  print "Content-type: text/html\n\n";
  
  print "<BR><CENTER>";
  print "<form><input type=button value=\"Success!\" onClick=\"locatio
+n.href('http://www.adskingston.com')\"></FORM>";
[download]

[reply]
[d/l]