in reply to Re: Why i am not able to print any statment after while loop
in thread Why i am not able to print any statment after while loop

Hii thanks for the reply.

Actually what i am trying to do is i have a file ListOfIpAdress.txt (please see below:) which i open and read it ($fhi do it in my code) i extract time from the string available.

ListOfIpAdress2.txt Address: 100.64.52.98 Time Fri Jan 16 21:44:35 2015 End Address: 100.65.0.172 Time Fri Jan 16 21:46:48 2015 End Address: 100.64.58.219 Time Fri Jan 16 22:56:16 2015 End Address: 100.65.5.25 Time Fri Jan 16 23:10:04 2015 End Address: 100.64.8.184 Time Fri Jan 16 23:52:54 2015 End Address: 100.65.13.135 Time Fri Jan 16 23:59:46 2015 End

Using my code i find the difference between the local time (current time and the time extracted from string).And in which ever line i get the time >36. I just ignore that line and read other lines and print them in ListOfIpAdress2.txt and then delete ListOfIpAdress.txt and Rename ListOfIpAdress2.txt to ListOfIpAdress.txt

This is what i wanted to achieve and still not able to achieve. Could you please help me ? My previous code is able to print extracted lines in ListOfIpAdress2.txt but it is not able to delete ListOfIpAdress.txt and rename it to ListOfIpAdress.txt.

Please alo let me know why it do not print"check1 and check2" again if in your c0ode i read the file like this " open my $fhi, '<', 'C:\shekhar_Axestrack_Intern\WindowCreation\ListOfIpAdress.txt', or die "Could not open file $!";"

Replies are listed 'Best First'.
Re^3: Why i am not able to print any statment after while loop
by Laurent_R (Canon) on Jan 18, 2015 at 11:47 UTC
    OK, I tried again with an external input file so that it looks more like your code. And it succeeds perfectly. The only thing that does not get done is the renaming of ListOfIpAdress2.txt into ListOfIpAdress.txt, because you don't have any code doing that.

    Below are the code I tested and the results.

    Please show your output, tell us if the source file gets deleted, show us any error message or warning. There are quite a few things that could be improved in your code, but it should basically work, since the slightly modified version I used is working on my computer (except of course for the final renaming that needs to be added to your code).

    Je suis Charlie.
      Hey done...the problem was in text file..it had some extra space because of click on it deleted it and copied 6 lines and pasted it and it worked for me. Thanks
      Hi Laurant,

      I am sorry but stil not working in my Laptop. Please see snapshot. http://prntscr.com/5txpl6 Neither it even not render output in ListOfIpAdress2.txt now and also not deleting ListOfIpAdress.txt

      Here is my full code:

      use strict; use Time::Local; use warnings; my $counter = 0; my($address) = @_; my $str; my $flag=0; my $file = 'C:\shekhar_Axestrack_Intern\WindowCreation\ListOfIpAdress2 +.txt'; open my $fho, '>', 'C:\shekhar_Axestrack_Intern\WindowCreation\ListOfI +pAdress2.txt' or die "Could not open file $!"; open my $fhi, '<', 'C:\shekhar_Axestrack_Intern\WindowCreation\ListOfI +pAdress.txt' or die "Could not open file $!"; while (my $line = <$fhi>) { my ($a1, $a2, $a3, $Day, $sMonth, $sDate, $sTime, $SYear,$a9, $a1 +0) = split(/ {1,}/, $line); my $str1= $sMonth." ".$sDate." ".$sTime ; my $scTime = localtime; my ( $cDay, $cMonth, $cDate, $cTime, $cYear,$Syear) = split(/ {1, +}/, $scTime); my $str2= $cMonth." ".$cDate." ".$cTime ; use constant Year => 2015; my $t1 = convert($str1); my $t2 = convert($str2); my $Diff= $t2 - $t1; my $div = $Diff/3600; print "Total Difference in Hour is : $div \n\n"; print $fho $line unless $div > 41; } print "\nn check1 \n\n"; close $fho; print "\nn check2 \n\n"; unlink ($file); if(-e $file) { print "File still exists!"; } else { print "File gone."; } sub convert { my $dstring = shift; my %m = ( 'Jan' => 0, 'Feb' => 1, 'Mar' => 2, 'Apr' => 3, 'May' => 4, 'Jun' => 5, 'Jul' => 6, 'Aug' => 7, 'Sep' => 8, 'Oct' => 9, 'Nov' => 10, 'Dec' => 11 ); if ($dstring =~ /(\S+)\s+(\d+)\s+(\d{2}):(\d{2}):(\d{2})/) { my ($month, $day, $h, $m, $s) = ($1, $2, $3, $4, $5); my $mnumber = $m{$month}; # production code should handle erro +rs here timelocal( $s, $m, $h, $day, $mnumber, 1900 ); } else { die "Format not recognized: ", $dstring, "\n"; } }
      Any Idea why ?
        Your $file variable contains the name of the output file, so that when you do:
        unlink ($file);
        you actually delete the output file instead of deleting the input file.

        Otherwise, don't worry too much about the "uninitialized" warnings you get (in your screen shot), they are most probably due to an empty line at the end of your input file, so that the $sMonth, $sDate, $sTime variables don't get populated for that empty line. Just add a line like this:

        next unless defined $sMonth;
        after the split (just after line 14), and this should suppress these warnings.

        Je suis Charlie.
        Sorry it prints the IP address in ListOfIpAdress2.txt ON CHANGING (36 TO 42 because it only prints the line whose TIME IS LESS THAN 42).

        But it still do not delete the ListOfIpAdress.txt Why that i dont know yet.