in reply to Re^3: Inline::C and NULL pointers
in thread Inline::C and NULL pointers

I think I see how typemaps work (bug, skip to end) 

...

xsubpp
-typemap "...lib\ExtUtils\typemap"
-typemap "...inline-c-mytypemap-null\mytypemap.txt"

[download]

https://metacpan.org/pod/xsubpp I see 

typemap typemap

    Indicates that a user-supplied typemap should take precedence over
+ the default typemaps. This option may be used multiple times, with t
+he last typemap having the highest precedence.

[download]

But it seems by using  unmapped     T_PTR you're getting the old T_PTR, not the new one, you can't redefine T_PTR, which makes sense

Actually it would seem that default typemap is clobbering your typemap definitions 

#!/usr/bin/perl --
use strict;
use warnings;
use Path::Tiny qw/ path /;
use Inline C =>
    Config =>
        BUILD_NOISY => 1,
        CLEAN_AFTER_BUILD => 0,
        typemaps => path( __FILE__ )->realpath->parent->path('mytypema
+p.txt'),
        NAME => 'markong',
        FORCE_BUILD => 1, ## debuggery
;;;;;;;;;;;;;

use Inline 'C' => <<'CODE';


typedef unsigned char * unmapped;

unmapped foo(unmapped name) {
  if(name) printf("True\n");
  else printf("False\n");
  return(NULL);
}

unsigned char * bar() {
  return (foo(NULL));
}


CODE

use Devel::Peek qw/ Dump /;
foo(undef);
bar();
exit( 0 );

__END__

[download]

...
Finished Build Compile Stage

INPUT Too_PTR= at inline-c-mytypemap-null-11139712.pl line 46.
Use of uninitialized value in subroutine entry at inline-c-mytypemap-null-11139712.pl line 46.
False
OUTPUT Too_PTR= at inline-c-mytypemap-null-11139712.pl line 46.
False



## cannot redefine T_PTR INPUT/OUTPUT
#  unmapped     T_PTR
unmapped     Too_PTR

brokenmapped    T_PTR

# cannot redefine typemap for "unsigned char*"
unsigned char *        Foo_PTR

INPUT
T_PTR
    $var = BROKEN_INT2PTR($type,SvIV($arg))


Too_PTR
    STMT_START {
        Perl_warn(aTHX_ \"INPUT Too_PTR=%s\", $arg);
        $var = INT2PTR($type,SvIV($arg));
        
    } STMT_END ;

Foo_PTR
    STMT_START {
        Perl_warn(aTHX_ \"INPUT Foo_PTR=%s\", $arg);
        $var = INT2PTR($type,SvIV($arg));
        
    } STMT_END ;

OUTPUT

Too_PTR
    STMT_START {
        Perl_warn(aTHX_ \"OUTPUT Too_PTR=%s\", $arg);
        sv_setiv($arg, PTR2IV($var));
        
    } STMT_END ;


Foo_PTR
    STMT_START {
        Perl_warn(aTHX_ \"OUTPUT Foo_PTR=%s\", $arg);
        sv_setiv($arg, PTR2IV($var));
        
    } STMT_END ;

T_PTR
    sv_setiv($arg, BROKEN_PTR2IV($var));

[download]

Digging down T_PTR is clobbered even if you don't specify the default typemap (see output of program, BROKEN_ gets replaced )

#!/usr/bin/perl --
use strict;
use warnings;

use ExtUtils::ParseXS::Utilities qw/  process_typemaps /;
use Data::Dump qw/ dd /;

dd( process_typemaps( './mytypemap.txt', ) );


__END__

[download]

So it makes sense or its documentation bug or behavior bug ... I dunno , I haven't used a keyboard in 6 months

  • Comment on Re^4: Inline::C and NULL pointers ( override default xsubpp ExtUtils::ParseXS::Utilities::process_typemaps )
  • Select or Download Code

Replies are listed 'Best First'.
Re^5: Inline::C and NULL pointers ( override default xsubpp ExtUtils::ParseXS::Utilities::process_typemaps )
by syphilis (Archbishop) on Dec 20, 2021 at 04:30 UTC
    Indicates that a user-supplied typemap should take precedence over the default typemaps. This option may be used multiple times, with the last typemap having the highest precedence.

    Thanks for digging that up.
    I really do think it would be better if our user-supplied typemap took precedence over ExtUtils/typemap. (This is something that should probably be investigated further.)

    But it seems by using unmapped T_PTR you're getting the old T_PTR, not the new one, you can't redefine T_PTR, which makes sense.

    My T_PTR is the same as the original T_PTR, as there was nothing wrong with the original.
    I just had to change the typing of unsigned char* from T_PV to T_PTR. I could only make that switch for the unmapped type, which was a typedef of unsigned char*.
    Seems I won't need that typedef if I can get the two typemaps to load in the reverse order.

    I've just checked and found that I didn't need to provide the T_PTR "INPUT" and "OUTPUT" routines in my custom typemap ("nullmap.txt").
    That file needs only to consist of: 
    unmapped     T_PTR

    [download]
    and the T_PTR "INPUT" and "OUTPUT" routines will be read from ExtUtils/typemap.
    Apologies - I did wonder about that at the time, but didn't spend the 10 seconds it takes to find out.
    'Twould have been much clearer if I had presented the one-line "nullmap.txt" instead of the multi-line version with its "INPUT" and "OUTPUT" sections.

    Cheers,
    Rob
[reply]
[d/l]
[select]
      I really do think it would be better if our user-supplied typemap took precedence over ExtUtils/typemap.

      Turns out it does ... but only if it's named "typemap" and is in the current working directory. (Calling it something else is alone insufficient - on my Windows 7 system, at least.)
      It then turns out that there's no need for the typedeffing either.

      This is a much simpler way of ensuring that undef is passed as a NULL:
      1) Have a file named exactly "typemap" in the cwd that contains the following single line (ending in a newline): 
      unsigned char *     T_PTR

      [download]
      2) The following demo script then passes 'undef' as a NULL to the C function foo(): 
      use strict;
use warnings;

use Inline C => Config =>
  BUILD_NOISY => 1, # verbose build
  FORCE_BUILD => 1, # re-build whenever the script is run
  CLEAN_AFTER_BUILD => 0, # don't clean up the build directory
;

use Inline C =><<'EOC';

unsigned char *foo(unsigned char *name) {
  if(name) printf("True\n");
  else printf("False\n");
  return(NULL);
}

EOC

foo(undef);

__END__
Outputs:
Use of uninitialized value in subroutine entry at try2.pl line 20.
False

      [download]
      I don't know why naming the typemap to something other than "typemap" should be inadequate - even stranger that it then could be made to work if unsigned char* was typedeffed to something else.
      Unless I can find some documentation that explains that weirdness, then I can only think that it's an Inline::C bug.
      I'll investigate that this issue and try to come up with a patch that fixes it if it's indeed a bug.

      Note that the file named "typemap" gets found automatically if it's located in the CWD. There's no need to engage the "TYPEMAPS" configuration option.

      UPDATE: It seems that a file named "typemap" will also be found and used automatically if it's in the .. or the lib/ExtUtils directory.
      If it's not called "typemap" && it's not in lib/ExtUtils or . or .. directories, then its location will be passed on to xsubpp (which will acknowledge that it has been informed of the file's existence) if and only if the file's location is specified in the 'TYPEMAPS' Config entry.
      But then xsubpp just silently ignores it completely unless it maps a type not covered by the files named "typemap" that were automatically found. (Hence my "nullmap.txt" from a previous post was able to be used.)
      As Bill Burroughs once said, "this is *insane* ... this *is* insane ... *this* is insane".
      Where should issues/PRs for EU::ParseXS be filed ? .

      Cheers,
      Rob
[reply]
[d/l]
[select]
[reply]

In Section Seekers of Perl Wisdom