in reply to Re^5: checking a set of numbers for consistency mod p
in thread checking a set of numbers for consistency mod p

You should also know which primes to expect. Probably all less 32?

In general, any prime p less than the size of the set, ie p should be small enough that it's possible to have 2 entries divisible by p. As you surmise, for the specific case that implies p < 32.

.. provided valid_set() works flawlessly. ;-)

I recommend taking that as given, until you actually find reason to believe it is flawed.

(and later) here my take on it

Thanks, I'll make time today or tomorrow to go through it and try to actually understand your algorithm.

  • Comment on Re^6: checking a set of numbers for consistency mod p

Replies are listed 'Best First'.
Re^7: checking a set of numbers for consistency mod p (update: still buggy)
by LanX (Saint) on Apr 11, 2022 at 20:17 UTC
    > Thanks, I'll make time today or tomorrow to go through it and try to actually understand your algorithm.

    I'd start with automated testing, I'm not 100% sure it holds for all cases with "holes".

    update

    in hindsight ... it's still producing false negatives:

    That's what the algo does with [3, [1, 0, 0, undef, 0, 0, 1]

    . . 1 0 0 ? 0 0 1 0 0 1 0 0 1 0 0 2 0 0 1 0 0 1 0 ^ *

    That's how it should fit

    . . . . . 1 0 0 ? 0 0 1 0 0 1 0 0 1 0 0 2 0 0 1 0 0 1 0 ^

    Sorry!

    Cheers Rolf
    (addicted to the Perl Programming Language :)
    Wikisyntax for the Monastery

      If I read it correctly, you currently make a sieve of length 2 * range, centred around pmax. I think you need the length to be around 2 * (range + pmax - 1).

      I don't understand the logic you're using with $max_pos to decide where in the sieve to match, and I'm not sure it's correct. But I'd be tempted to punt on that - make both sieve and input into strings as below, and use a regexp match.

      use List::Util qw{min}; my @order = '0' .. '9', 'A' .. 'Z'; # range of 2^36 is probably enou +gh sub to_string { my($max, $list) = @_; return join '', map { defined($_) ? $order[min($_, $max)] : '.' } @$list; }
        first of all, the algorithm as it is now is only reliable if a hole doesn't hide a max. Otherwise you get false negatives like demonstrated here

        You will need to cover that!

        I have some efficient ideas, but no time right now.

        ( These kind of riddles cost me a lot of processing power I need elsewhere. :)

        > make a sieve of length 2 * range

        that's sufficient because range can always fit in that sliding window.

        I shift the window to the right by pmax_known+n if positioning the first max means a negative sieve index.

        It's important to realize that this can only happen with preceding holes covering a former max. Hence these holes will also ignore the position pmax+n in the sieve. °

        > make both sieve and input into strings as below, and use a regexp match.

        Not sure I understand, but the fastest way to compare two byte arrays is to xor the strings, a range of 256 or even 128 exponents should be sufficient

        Of course representation of holes, like \xFF or \x00 makes this more challenging, needing a second and

        But I consider this premature optimization, you should first test the validity of the algorithm with arrays.

        Cheers Rolf
        (addicted to the Perl Programming Language :)
        Wikisyntax for the Monastery

        °) Maybe it's even not necessary to try successive n and you can just shift by pmax - this equals swapping the sequence to the second half.

        update

        ... to come...

        ... OK ... It's important to understand that those shifts and other problems are only due to one or more holes covering an e >= max ...

        Without holes the algorithm works as is!

        Now one needs to list the possible cases, for e=max and e >max and shift accordingly by + pe for all "dubious" holes till one has a pass or all failed.

        There might be a simple solution like moving the first hole to pmax+1 and taking advantage of the fact that further collisions are not possible because of the constraints (first max) but I can't wrap my head around it.