in reply to Re^2: [challenge] Nested autocompletion -- results and some question
in thread [challenge] Nested autocompletion
I need to stop trusting code by others, even if by experienced programmers like you :)
It comes out ReadKey.pm is generated from ReadKey.pm.PL and generates different output on different systems: so on linux it checks for undefined values while on win32 it does not. To me this is bug so I created an issue.
The docs of Term::ReadKey say you need to pass a MODE to the ReadKey function.
So instead of my $char = ReadKey; you need instead my $char = ReadKey(-1); next unless defined $char;
For future convenience here is the patched version of your second program, fixed for win32:
#!/usr/bin/perl use strict; # original code posted by tybalt89 at https://perlmonks.or +g/?node_id=11150326 use warnings; # constant autocomplete use List::Util qw( uniq ); use Term::ReadKey; $| = 1; my @animals = (qw( cow camel dog cat )); my @foods = (qw( fish pasture meat )); my @places = (qw( wood sea desert )); my $commands = { select => { completion_list => \@animals, commands => { give => { completion_list => \@foods, }, take_to => { completion_list => \@places, }, }, }, kill => { completion_list => \@animals, } }; my $completed = autocomplete( $commands, 'auto> ' ); print $completed ? "\nThe user entered: $completed\n" : "\nEscape\n"; exit; ###################################################################### sub autocomplete { my $commands = shift; my $prompt = shift // '> '; my $lines = ref $commands ? join "\n", lines($commands), '' : $comma +nds; my $input = ''; my ($clearline, $color, $reset) = ("\e[G\e[K", "\e[32m", "\e[m"); ReadMode 'raw'; eval { while() { $input = "$input\n$lines" =~ /^(.*).*\n(?:.*\n)*\1/ ? $1 : ''; $input = $lines =~ s/^(?!\Q$input\E).*\n//gmr =~ /^(.*).*\n(?:\1.*\n)*\z/ ? $1 : ''; my $words = join ' ', sort + uniq $lines =~ /^\Q$input\E ?(\S+)/ +gm; $lines =~ /^$input\n/m and $words = '*** Completed!'; my $backup = "\e[" . ( 2 + length $words ) . "D"; print "$clearline$prompt$input $color$words$reset$backup"; my $char = ReadKey(-1); next unless defined $char; # you need this on Win32 $char =~ tr/\e\cc// and $input = '', last; $char =~ tr/\n\r// and $lines =~ /^$input$/m ? last : next; $char =~ tr/ -~// and $input .= $char; if( $char =~ tr/\b\x7f// ) # backspace { my $match = 1 + ( () = $lines =~ /^\Q$input\E/gm ); $input = "$input\n$lines" =~ /^(.*).*\n(?:(?:(?!\1).*\n)*\1.*\n){$match}/ ? $1 : ''; } } 1; }; my $error = $@; ReadMode 'restore'; print "$error\n"; return $input; } sub lines { my $cmd = shift or return ''; map s/ +$//r, map { my $key = $_; # fun triple map nesting map { my $prev = $_; map "$key $_ $prev", @{ $cmd->{$key}{completion_list} }; } lines( $cmd->{$key}{commands} ) } keys %$cmd; }
L*
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^4: [challenge] Nested autocompletion -- fixed win32 version
by tybalt89 (Monsignor) on Feb 21, 2023 at 16:06 UTC | |
by Discipulus (Canon) on Feb 23, 2023 at 09:33 UTC | |
by roho (Bishop) on Feb 22, 2023 at 08:08 UTC | |
by Discipulus (Canon) on Feb 23, 2023 at 09:02 UTC | |
by roho (Bishop) on Feb 24, 2023 at 07:02 UTC |