in reply to Re: Testing image output
in thread Testing image output
Sounds good to me
It might sound like a good approach...but...it's failing under testing 😕
But, I'm not sure what could be producing this failure other than different builds of GD producing slightly different outputs or the hashing being subtly different on Linux where it is failing to Windows where I am developing. I specified the image quality with $new->jpeg(50) to try and keep GD consistent across builds.
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^3: Testing image output
by hippo (Archbishop) on Sep 11, 2023 at 09:45 UTC | |
So, it's JPEG. :-) I agree with our Anonymous friend who wrote: no JPGs in t folder, because same image file can't be expected to decode to same data. Maybe use a lossless format instead for this level of testing and then separately just confirm that using JPEGs doesn't error out? Or else see how other JPEG modules handle it in their test suites. 🦛 | [reply] [d/l] |
Re^3: Testing image output
by Anonymous Monk on Sep 14, 2023 at 18:10 UTC | |
omg, ain't GD so very difficult. I'm looking at Image-Square 0.01_4 testers matrix, what was supposed to be walk in the park is like blood covered battlefield. Half failures are from gd native output format unsupported, who could expect. I'm sorry. It isn't really a problem, because ".gd" is just 11 bytes header plus raw data:
Note, one checksum is exactly what "t/02-image.t line 41" was expecting, but the latter is what many (but not all) failures have "got". It appears that copyResampled (and interpolation in general, see further) is unstable between versions and plagued with bugs. Then, even generating synthetic gradient or whatever, and checking for just couple of pixels (e.g. lower left and upper right points) is NOT reliable way to test anything with GD, let alone calculating checksum over whole re-sampled image. No CoventryCathedral for tests below, simply a red 8 by 8 square to reduce to smaller squares:
Oh, I thought, but I'm copying red pixels to another (smaller) canvas, filled with default black. Maybe, instead, plain simple resize would preserve pure red colour? Note, plain "resize" was not implemented in old versions anyway.
Wait, but there are a few dozen interpolation methods:
I have no idea why 3,4,5 i.e. GD_BILINEAR_FIXED, GD_BICUBIC, GD_BICUBIC_FIXED, are not ok i.e. don't preserve dumb uniform fill of dumb square canvas. I'd laugh out load if asked will this list stay stable for near future. I have much sympathy for GD, but above was a little bit too much.
| [reply] [d/l] [select] |
by Bod (Parson) on Sep 14, 2023 at 22:53 UTC | |
omg, ain't GD so very difficult. I'm looking at Image-Square 0.01_4 testers matrix, what was supposed to be walk in the park is like blood covered battlefield. I know my knowledge of images is lacking but I was beginning to feel I had done something terribly wrong... No CoventryCathedral for tests below, simply a red 8 by 8 square to reduce to smaller squares Isn't the whole point of the tests to check that the module does what it is supposed to in real situations? Users of the module (me if I am the only one) will be using ti to process large, if not huge, images. If it passes the tests on little tiny images but fails on large ones, doesn't that sort of render the tests meaningless? My original tests were based on those in Image::Resize in the < href="https://metacpan.org/release/SHERZODR/Image-Resize-0.5/source/t/1.t"1.t</code> file which just checks the dimensions of the generated file. But that module doesn't crop images which is why I wanted to include tests of the actual output. It appears that copyResampled (and interpolation in general, see further) is unstable between versions and plagued with bugs I did originally use copy but changed to copyResampled when I decided it would be sensible to add the facility to change the size at the same time... | [reply] [d/l] [select] |
by pryrt (Abbot) on Sep 15, 2023 at 14:13 UTC | |
Isn't the whole point of the tests to check that the module does what it is supposed to in real situations? To some extent, the "large image" tests that you are suggesting have nothing to do with the behavior of the specifics of your module, because all the logic of your module can be tested with a 3x1 and a 1x3 image. Whether GD::Image::copyResampled works under every situation is outside of your control -- but it is to be expected that libgd and/or the GD::Image wrapper around that library together have sufficient tests on copyResampled to ensure that it works in any situation they claim it will work. The copyResampled docs say, "using a weighted average of the pixels of the source area rather than selecting one representative pixel" -- what happens if they decided to slightly tweak the weights used between one version of the library and another, because it gives similar but slightly better results from the visual perspective on certain images? Your test would be looking for the specific results based on factors outside of your control, so two different machines with different versions of libgd might give a different signature, even though the image is still reasonably resized and resampled. Because the underlying libgd library can be changed without changing the GD wrapper distribution, or the GD wrapper distribution could be changed without changing libgd, you cannot (even if it is possible) just restrict your module to require an exact version of GD -- because the version of GD doesn't guarantee a specific version of the library. So you have no way of restricting to a specific libgd version, and thus no way to guarantee that the underlying behavior of that function will always deterministically give a single known output for a given input, across all versions of the library that might be on a user's machine now or in the future. The two three-pixel images that I suggested in my github comment seem to me to be immune to such differences, because if you specify the squares so they land on exact pixel boundaries (which is what I did), there should never be a need for averaging/interpolating, and so as far as I can tell, they would not be affected by any reasonable changes to the copyResampled algorithm -- though I might be proven wrong at some point if they got really "creative" with their implementation. If you are really worried about large images behaving weirdly, I can think of a few options:
edit: finished a dangling sentence, and rephrased slightly. | [reply] [d/l] [select] |
by Bod (Parson) on Sep 15, 2023 at 23:05 UTC | |
by Anonymous Monk on Sep 16, 2023 at 11:02 UTC |