Re: Code review

Code review: Use meaningful variable names.

Update: The following is wrong. Ignore it.

Simplification:

foreach (@ARGV) { $Y{$y}++,next if $y eq $_;  }
[download]

next is not needed here as there's nothing happening after it, anyway.
Once we removed next, we can see it basically counts how many times $y appears in @ARGV, so a bit more readable way might be
```
    $Y{$y} += grep $y eq $_, @ARGV;
[download]
```
This automatically does anything only when @ARGV is not empty (as otherwise, grep returns 0). What can we do to get rid off the if? Well, if @ARGV is empty, we want to increase $Y{$y} by one, which could be achieved by
```
    $Y{$y} += (grep $y eq $_, @ARGV) || 1;
[download]
```
This can replace the whole if/else.

It's unclear what happens in the ellipses. Note that if 0 is in @ARGV, it won't be counted in %Y because of next unless $y.

map{substr$_->[0],$_->[1]||0,1}[\*||{},3],[[]],[ref qr-1,-,-1],[{}],[sub{}^*ARGV,3]

Comment on Re: Code review Select or Download Code

Replies are listed 'Best First'.
Re^2: Code review by Danny (Chaplain) on Mar 06, 2024 at 16:37 UTC
$Y{$y} += (grep $y eq $_, @ARGV) \|\| 1; In the OP, it looks like if @ARGV is true but no $y matches $_ then $Y{$y} should not be incremented. But the above code will increment it.	[reply]
Re^3: Code review by choroba (Cardinal) on Mar 06, 2024 at 16:43 UTC
You're right, my bad. `map{substr$_->[0],$_->[1]\|\|0,1}[\\|\|{},3],[[]],[ref qr-1,-,-1],[{}],[sub{}^ARGV,3]`	[reply] [d/l]