Re: Passing a hash plus some strings to a subroutine

It's just moaning about your use of individually shifting the args. This passes perlcritic --stern for me:

sub generate {
    my ($record, $status, %data) = @_;
    return;
}
[download]

🦛

Comment on Re: Passing a hash plus some strings to a subroutine Select or Download Code

Replies are listed 'Best First'.
Re^2: Passing a hash plus some strings to a subroutine by ikegami (Patriarch) on Dec 17, 2025 at 15:35 UTC
Nothing wrong with shifting. Easier to provide defaults and comments. And then there's the newish signature feature. Take perlcritic's critiques with a grain a salt, and adjust them to your liking.	[reply]
Re^2: Passing a hash plus some strings to a subroutine by LanX (Saint) on Dec 17, 2025 at 15:55 UTC
Not the same thing tho. The OP is passing a hashref, but you are un- and repacking a hash as list of keys and values. Cheers Rolf _{(addicted to the Perl Programming Language :) see Wikisyntax for the Monastery}	[reply]