Re: Advice on best practices

I appreciate everyone taking the time to respond. I am really just looking for technical answers here, like what Anonymous Monk has provided. I provided 4 examples, and I'm just looking to know if those are standard/best practices. I provided some context to my question, just because I thought it generally helps to explain the context of a question. While I appreciate your advice, I'm comfortable with how to handle it with the customer. The only issue I am seeking advice on (and why I came to Perl Monks) is to know the if those 4 techniques are implemented in standard/best practices. For example, if you hired a developer and he wrote code like the examples I provided, would you find it acceptable? Is it the right way to do those things? Feedback, like from Anonymous Monk, is what I was looking for, and how I phrased my question. (Maybe I should have left out the context?)

To answer the other comments about worry if the other developer find this...That isn't a concern. I'd expect if he knew of Perl Monks, he would have seen some other code examples and utilized other perl modules and not written the code as he did. Even so, if he does find it, he will know I at least took the time to check before I brought it up to him. If someone took the time to first check with knowledgeable people to see if my code wasn't up-to-par before they questioned it, I would actually appreciate that. At least they cared enough to check first before making ignorant statements. I'd like to discuss it with him from a more knowledgeable position, and not being a perl developer for many years, I feel like some additional feedback from some perl pros would help with that. ex, I say "Wondering why you did XYZ that way?", he says "Because thats the best way!". "Best" imho means it was done in best practices, in a standard, most efficient way. What I'm getting so far is, its mostly in the "gray area". Some would do it differently, but its not "wrong". So, based on that, I would say its best for me to not even bring it up.

Comment on Re: Advice on best practices

Replies are listed 'Best First'.
Re^2: Advice on best practices by Anonymous Monk on Mar 06, 2015 at 01:07 UTC
... if those 4 techniques are implemented in standard/best practices. For example, if you hired a developer and he wrote code like the examples I provided, would you find it acceptable? Those are two different things, which is kind of what the earlier post was getting at. For example, I'd say copying/moving/deleting files via system is almost certainly not a best practice (the `File::*` modules are in the Perl core and therefore almost always available). Is it "acceptable"? Sometimes, if the appropriate care is taken and the strings being interpolated into the command are well-known. If it's fairly easy for you to find a test case that shows a failure, then it's a problem!	[reply] [d/l]

Replies are listed 'Best First'.

Re^2: Advice on best practices
by Anonymous Monk on Mar 06, 2015 at 01:07 UTC

... if those 4 techniques are implemented in standard/best practices. For example, if you hired a developer and he wrote code like the examples I provided, would you find it acceptable?

Those are two different things, which is kind of what the earlier post was getting at. For example, I'd say copying/moving/deleting files via system is almost certainly not a best practice (the File::* modules are in the Perl core and therefore almost always available). Is it "acceptable"? Sometimes, if the appropriate care is taken and the strings being interpolated into the command are well-known. If it's fairly easy for you to find a test case that shows a failure, then it's a problem!

[reply]
[d/l]