Re^6: Tidy up conditions

Hi again Martin,

I've incorporated the // in my code like this:

$item = 'Test';

$level =
        $access{$item} //
        ($item =~ /^([^:]+):/ && $access{"$1:*"}) //
        $access{'*'} //
        999;

print "level='$level'\n";
[download]

Unfortunately, when the regex doesn't match, it seems to short-circuit, and this is printed:
level=''

Any ideas why? I assume it's something to do with the line which contains the regex not being 'defined', but I'm not sure.

Meanwhile, I've worked around it by putting the regex first, like this:

$access{'*'} = 30;
$item = 'Test';

$item =~ /^([^:]+):/;
$level =
        $access{$item} //
        $access{"$1:*"}) //
        $access{'*'} //
        999;

print "level='$level'\n";
[download]

And I think that's working (i.e. it prints "level='30'" in the above case).
If you've got a better adjustment to this code, which doesn't involve using that regex unless needed, I'd love to see it. Otherwise, no worries - I'm pretty happy.

Thanks again.

Comment on Re^6: Tidy up conditions Select or Download Code

Replies are listed 'Best First'.
Re^7: Tidy up conditions (false) by tye (Sage) on Mar 21, 2015 at 03:28 UTC
Because `$item =~ /^([^:]+):/` gives a false value that is not an undefined value when it fails (and `$false && $blah` returns `$false` not undef and `$notundef // $blah` returns `$notundef` not `$blah`). - tye	[reply] [d/l] [select]
Re^8: Tidy up conditions (false) by tel2 (Pilgrim) on Mar 21, 2015 at 04:26 UTC
Well explained, tye. Thanks very much for that. Tel2	[reply]
Re^7: Tidy up conditions by martin (Friar) on Mar 22, 2015 at 02:33 UTC
You stated in your initial post that $item contained a string in the format 'X:Y'. If you were right, that match would of course not fail. However, if that precondition is dropped and the match is allowed to fail, your new code will put an undefined value $1 into a string when that failure happens. Undef stringifies to an empty string and all may seem well, but your future maintainer might wonder if you did this on purpose or just overlooked an edge case. How could the match fail? It fails if the first character is a colon or there is no colon at all. You could modify the match so that it still matches part X of an 'X:Y' string but never fails, like this: `$item =~ /^([^:])/; $level = $access{$item} // $access{"$1:"}) // $access{''} // 999;` [download] The match will now capture the whole string if there is no colon, and an empty string if the first character is a colon. If you want to assign the "Test:" level to item "Test" you are done. If you rather want to assign the "" level to item "Test" this can also be made foolproof. You could match with colon and look at the success of the match: `my $partial = $item =~ /^([^:]+):/ ? "$1:" : ''; $level = $access{$item} // $access{$partial}) // $access{''} // 999;` [download] And so on. I am not dogmatic about turning on warnings but consider it good style not to ignore what is defined and what isn't.	[reply] [d/l] [select]
Re^8: Tidy up conditions by tel2 (Pilgrim) on Jul 07, 2015 at 23:31 UTC
Thanks for that, martin. Just noticed your post recently.	[reply]
Re^7: Tidy up conditions by Anonymous Monk on Mar 21, 2015 at 02:53 UTC
Any ideas why? Basic debugging checklist says to find out use perl -MO=Deparse,-p yourprogram.pl	[reply]
Re^8: Tidy up conditions by tel2 (Pilgrim) on Mar 21, 2015 at 04:25 UTC
Thanks Anonymous Monk, Unfortunately, the output of: perl -MO=Deparse,-p test.pl doesn't tell me much (in this case): `($item = 'Test'); ($level = ((($access{$item} // (($item =~ /^([^:]+):/) && $access{"$1: +"})) // $access{''}) // 999)); print("level='${level}'\n"); test.pl syntax OK` [download] But thanks for the link to the other things on the debugging page.	[reply] [d/l]