$wfile = $cgi->param("toping");
$wfname = 'toping';
open (DAT,">/home/deruytja/webserver/rifucgi/temp_ul/$wfname") or die 
+'Error processing file INPUT: ',$!;
binmode $wfile;
[download]

$wfile = $cgi->param("toping");
open (my $dat,">", "/home/deruytja/webserver/rifucgi/temp_ul/$wfname")
+ or die 'Error processing file DAT: ',$!;
print $dat $wfile;
[download]

Hello kennethk,

frankly, I copied the routine for uploading a file (http://aktuell.de.selfhtml.org/artikel/cgiperl/file-upload/, a german HTML "learning" site) as I didn't had any clue how to do it in perl. I think it had something to do with uploading and converting the file.

If I modifie the code like that:

$wfile = $cgi->param("toping");                                       
+         #Upload Teil des Scripts
$wfname = 'toping';                                #Upload Teil des Sc
+ripts
open (my $DAT,">", "/home/deruytja/webserver/rifucgi/temp_ul/$wfname")
+ or die 'Error processing file INPUT: ',$!;             #Upload Teil 
+des Scripts
print $DAT $wfile;
[download]

I'll only get the filename written to my temp file (the "toping" one)

I've modified the bareword filehandles already (I know barewords are a bad practice and I can't remeber why I did it this way).

I'm mostly using google and the "trial and error" method for learning. Maybe you could point me to my problems? Especially the open arguments and the unescaped text.

I'm not a skilled programmer as I've learned more in the direction of hardware and planning

So $cgi->param("toping") contains the target file name. So that means you need to open the target file and input it. Mimicking the behavior of the original source material, you might do something like:

sub UPLOAD {
    $wfile = $cgi->param("toping");
    open(my $wfin, '<', $wfile) or die "Error opening $wfile: $!";

    $wfname = 'toping';
    open (my $datin,">", "/home/deruytja/webserver/rifucgi/temp_ul/$wf
+name") or die 'Error processing file INPUT: ',$!;
    binmode $wfin;
    binmode $datin;
    while (read $wfin, my($data), 1024) {
        print $datin $data
    }                          #Upload Teil des Scripts
}
[download]

With regard to reading material, there's a fair amount you could learn from Ovid's CGI Course - Resurrected and Updated! about good practice. He discusses taint and other security issues. It's worth noting that people generally don't use CGI directly any more. Specifically, the docs for CGI itself say

The rationale for this decision is that CGI.pm is no longer considered good practice for developing web applications, including quick prototyping and small web scripts. There are far better, cleaner, quicker, easier, safer, more scalable, more extensible, more modern alternatives available at this point in time.

Modules like Template::Toolkit (which is rolled into frameworks like Mojolicious, Dancer2 and Catalyst) allow for clean separation between your logic and layout, and can defaultly handle the character escaping.

---

#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.

Welcome deruytja,

I don't have a setup to test your code, but I call Perl from html all the time. I don't use the '<img ...' but use: ( example only )

<a href="/perl_script?Sid=eddie&... " target="main"><font size="-1"><b
+>Reset</b></font></a>
[download]

From your description of your problem, you may need to pass the undefined variables to the 2nd script via the GET/POST method.

Good Luck...Ed

my $safe_filename_characters = "a-zA-Z0-9_.-";
sub PLOTTING
{
my ($GRAPH_FH, $mygraph, $graphimage);
open ($GRAPH_FH, '>','/home/deruytja/webserver/output/multiping/'.$gra
+phname.'.png');  #Redirecting Standart Error to file

$mygraph = GD::Graph::linespoints->new(500, 300);
$mygraph->set(
    x_label     => 'Link',
    y_label     => 'Antwortzeit in ms',
    title       => 'Antwortzeiten der Links',
    dclrs         => ['green'],
    y_max_value    => $max,
    bar_spacing => 10,
    show_values => 1,
) or warn $mygraph->error;
$graphimage = $mygraph->plot(\@graphdata);
binmode $GRAPH_FH;
print $GRAPH_FH $graphimage->png;
close $GRAPH_FH;
}
[download]

Also I modified the upload script after encountering problems regarding filenames (If they've got ä/ö/ü in it) like this:

sub UPLOAD
{
my $filename = $cgi->param('toping');
if ( !$filename )
    {
    print $cgi->header ( );
    print 'There was a problem uploading your file (try a smaller file
+).';
    exit;
    }
my ( $name, $path, $extension ) = fileparse ( $filename, '..*' );
$filename = $name . $extension;
$filename =~ tr/ /_/;
$filename =~ s/[^$safe_filename_characters]//g;

if ( $filename =~ /^([$safe_filename_characters]+)$/ )
{
$filename = $1;
}
else
{
    print $cgi->header();
    print 'There was a problem with the filename (please rename).';
    exit;
}

my $wfile = $cgi->upload('toping');
open(my $DAT,">", "/home/deruytja/webserver/rifucgi/temp_ul/toping.$da
+te") or die 'Error processing file INPUT: ',$!; 
binmode $DAT;
while (read $wfile, $data, 1024) 
    {
    print $DAT $data
    }   
close $DAT;
}
[download]

The user could also give the output file a name, which would encounter the same problems with the characters, solved via this piece of code:

if (!length($dateiname) == 0 && $dateiname =~ /^([$safe_filename_chara
+cters]+)$/)
        {
        $out_file = ("$dateiname\_$date.csv") or die 'Error processing
+ file: ',$!;
        $graphname = "$dateiname\_$date";
        }
else
        {
        print $cgi->header();
        print 'There was a problem with your file name, it was reverte
+d to "ping_" (please change output name).';
        $out_file = ("ping_$date.csv") or die 'Error processing file: 
+',$!;
        $graphname = "ping_$date";
        }
[download]