Re^5: Refactoring technique?

Lucky for you that want the oo[a] notation instead of oo.x notation. I am mostly positive that Javascript cannot interpolate a method call at runtime. Consider the following:

#!/usr/bin/node

var key = 'id';
var obj = { id: 123, key: "wrong key!" };

function do_meth( obj, key ) {
    return obj.key;
}

function do_windex( obj, key ) {
    return obj[key];
}

console.log( do_meth( obj, key ) );
console.log( do_windex( obj, key ) );
[download]

When run, do_meth returns "wrong key!" instead of 123. You have to hard code return obj.id ... or use bracket notation such as you desire.

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

Comment on Re^5: Refactoring technique? Download Code

Replies are listed 'Best First'.
Re^6: Refactoring technique? by BrowserUk (Patriarch) on Apr 24, 2015 at 22:36 UTC
That's good news, and thanks for the test script. This reflects the type of substitutions I need: `#!/usr/bin/node var vec = { x: 1, y: 2, z:3 }; var obj = { id: vec, key: 'Wrong key!' }; function do_meth( obj ) { return obj.id.y; } function do_windex( obj, key ) { return obj[key].y; } var key = 'id'; console.log( do_meth( obj ) ); console.log( do_windex( obj, key ) );` [download] Where do_meth() is how it is, and do_windex() is how I need it to be. And, it works for my big example. At least mostly. There is still something that isn't quite right; some small difference I haven't tied down and parameterised properly. With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday' Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error. "Science is about questioning the status quo. Questioning authority". I'm with torvalds on this In the absence of evidence, opinion is indistinguishable from prejudice. Agile (and TDD) debunked	[reply] [d/l]

Replies are listed 'Best First'.

Re^6: Refactoring technique?
by BrowserUk (Patriarch) on Apr 24, 2015 at 22:36 UTC

That's good news, and thanks for the test script. This reflects the type of substitutions I need:

#!/usr/bin/node

var vec = { x: 1, y: 2, z:3 };
var obj = { id: vec, key: 'Wrong key!' };

function do_meth( obj ) {
    return obj.id.y;
}

function do_windex( obj, key ) {
    return obj[key].y;
}

var key = 'id';

console.log( do_meth( obj ) );
console.log( do_windex( obj, key ) );
[download]

Where do_meth() is how it is, and do_windex() is how I need it to be. And, it works for my big example.

At least mostly. There is still something that isn't quite right; some small difference I haven't tied down and parameterised properly.

With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'

Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.

"Science is about questioning the status quo. Questioning authority". I'm with torvalds on this

In the absence of evidence, opinion is indistinguishable from prejudice. Agile (and TDD) debunked

[reply]
[d/l]