Re: Module Code Review

Your leap year calculation is incorrect. 2004 is a leap year, 2000 is a leap year, 1904 is a leap year, but 1900 is NOT. The rule is:

divisible by 4, and
not divisible by 100, or
divisible by 400

if (!($y % 4) and ($y % 100 or !($y % 400))) { ... }
[download]

Other than that, here's a much simpler method for finding out yesterday:

use Time::Local;

my $noon = timelocal(0,0,12, (localtime)[3,4,5]);
my ($d,$m,$y) = (localtime($noon - 86400))[3,4,5];
[download]

_____________________________________________________
Jeff[japhy]Pinyan: Perl, regex, and perl hacker.
s++=END;++y(;-P)}y js++=;shajsj<++y(p-q)}?print:??;

Comment on Re: Module Code Review Select or Download Code

Replies are listed 'Best First'.
(tye)Re: Module Code Review by tye (Sage) on Sep 15, 2001 at 09:58 UTC
You don't even need Time::Local, `my $yesterday= do { my($y,$m,$d)= (localtime( time-6060(12+(localtime)[2]) ))[5,4,3]; sprintf "%04d-%02d-%02d", 1900+$y, 1+$m, $d; };` [download] or, just for fun: `my $yesterday= join"-",mapcar{sprintf "%0".shift()."d",pop()+pop()} [4,2,2],[(localtime( time-6060(12+(localtime)[2]) ))[5,4,3]],[1900,1,0];` [download] - tye (but my friends call me "Tye")	[reply] [d/l] [select]

Replies are listed 'Best First'.

(tye)Re: Module Code Review
by tye (Sage) on Sep 15, 2001 at 09:58 UTC

You don't even need Time::Local,

my $yesterday= do {
    my($y,$m,$d)= (localtime(
        time-60*60*(12+(localtime)[2]) ))[5,4,3];
    sprintf "%04d-%02d-%02d", 1900+$y, 1+$m, $d;
};
[download]

my $yesterday= join"-",mapcar{sprintf "%0".shift()."d",pop()+pop()}
[4,2,2],[(localtime(
time-60*60*(12+(localtime)[2]) ))[5,4,3]],[1900,1,0];
[download]

tye

[reply]
[d/l]
[select]