Re^2: "Unescaped left brace in regex is deprecated"

To make the test plan a bit more clear, maybe use some of the functions from Test::Exception to consolidate some operations. E.g., the last few tests above might be re-written (untested):

lives_ok {
    close  $fh  or die "closing '$f': $!";
    close  $wfh or die "closing '$wf': $!";
    unlink $wf  or die "unlinking '$wf': $!";
    } 
    'file cleanup ok';
dies_ok {
    open my $wfh, '<', $wf or die "opening '$wf': $!";
    }
    "after unlink of '$wf': cannot re-open for read";
[download]

(In place of dies_ok() you could use throws_ok() and check for a specific "file does not exist" error message.)

Give a man a fish: <%-(-(-(-<

Comment on Re^2: "Unescaped left brace in regex is deprecated" Select or Download Code

Replies are listed 'Best First'.
Re^3: "Unescaped left brace in regex is deprecated" by stevieb (Canon) on Jul 18, 2015 at 20:19 UTC
Thanks a lot AnomalousMonk, that's some great insight. I'll apply that to these types of tests for sure. I've also run into a situation where in a test I needed to run past an `exit()`, and am becoming familiar with Test::Trap. The following example hasn't yet incorporated your Test::Exception (I also noticed that I wasn't using strict or warnings which has turned out to be very significant for the stability and predictability of a test suite). #!perl -T use warnings; use strict; use Test::More tests => 8; use Test::Trap; BEGIN {#1 use_ok( 'Devel::Examine::Subs' ) \|\| print "Bail out!\n"; } my $des = Devel::Examine::Subs->new({ file => 't/sample.data', engine => 'all', }); {#2 - core dump my $file = 't/core_dump.debug'; do { eval { open STDOUT, '>', $file or die $!; }; ok (! $@, "STDOUT redirected for core dump"); my @exit = trap { $des->run({core_dump => 1}); }; eval { print STDOUT $trap->stdout; }; is (! $trap->stdout, '', "output to stdout" ); ok (! $@, "core dump gave no errors" ); }; eval { open my $fh, '<', $file or die $!; }; ok (! $@, "core dump output file exists and can be read" ); open my $fh, '<', $file or die $!; my @lines = <$fh>; is (@lines, 183, "Based on test data, core dump dumps the correct +info" ); eval { close $fh; }; ok (! $@, "core dump output file closed successfully" ); eval { unlink $file; }; ok (! $@, "core dump temp file deleted successfully" ); } [download] -stevieb	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: "Unescaped left brace in regex is deprecated"
by stevieb (Canon) on Jul 18, 2015 at 20:19 UTC

Thanks a lot AnomalousMonk, that's some great insight. I'll apply that to these types of tests for sure. I've also run into a situation where in a test I needed to run past an exit(), and am becoming familiar with Test::Trap.

The following example hasn't yet incorporated your Test::Exception (I also noticed that I wasn't using strict or warnings which has turned out to be very significant for the stability and predictability of a test suite).

#!perl -T
use warnings;
use strict;

use Test::More tests => 8;
use Test::Trap;

BEGIN {#1
    use_ok( 'Devel::Examine::Subs' ) || print "Bail out!\n";
}

my $des = Devel::Examine::Subs->new({
                            file => 't/sample.data',
                            engine => 'all',
                          });
{#2 - core dump

    my $file = 't/core_dump.debug';

    do {
        
        eval { open STDOUT, '>', $file or die $!; };
        ok (! $@, "STDOUT redirected for core dump");

        my @exit = trap { $des->run({core_dump => 1}); };

        eval { print STDOUT $trap->stdout; };
        is (! $trap->stdout, '', "output to stdout" );
        ok (! $@, "core dump gave no errors" );

    };

    eval { open my $fh, '<', $file or die $!; };
    ok (! $@, "core dump output file exists and can be read" );
    open my $fh, '<', $file or die $!;
    
    my @lines = <$fh>;
    is (@lines, 183, "Based on test data, core dump dumps the correct 
+info" );

    eval { close $fh; };
    ok (! $@, "core dump output file closed successfully" );

    eval { unlink $file; };
    ok (! $@, "core dump temp file deleted successfully" );
}
[download]

-stevieb

[reply]
[d/l]
[select]