no exit!

doc1623 has asked for the wisdom of the Perl Monks concerning the following question:

This will probably be a Homer S. Doh... but why doesn't this exit. It prints the Match... and the error mesg I have in a separate function then I see the ..passed print.. If tried exit as well. Thanks for any/all help


sub getsql{
        my $dbh = shift;
        my $script = shift;
        my $insert= shift;
        local $/ = undef;
        open FILE, '<', $script, or die "Couldn't open SQL file";
        my $insql = dwindex(<FILE>);
        my $outsql;
        if (length $insert) { 
                $outsql = getinserts($insql,$insert);
        }
        else {
                print "in else:$insql\n";
                if ($insql =~ m/.*~\w+~.*/) {print "MATCHED IT\n";}
                errmsg(1) && die if ($insql =~ m/.*~\w+~.*/);
                print "pased*********************\n";
                $outsql = $insql;
        }
        close FILE;
        return $outsql;
}
[download]

Comment on no exit! Download Code

Replies are listed 'Best First'.
Re: no exit! (return) by tye (Sage) on Aug 14, 2015 at 16:58 UTC
Is errmsg() returning a false value? - tye	[reply]
Re^2: no exit! (return) by doc1623 (Novice) on Aug 14, 2015 at 18:56 UTC
You were right! Sorry Couldn't see the forest through the trees. I had it printing a string..not returning one! `MATCHED IT insert value/count mismatch: no insert value entered Died at db.pl line 51, <FILE> chunk 1` [download] Thanks everyone... DOH.....	[reply] [d/l]
Re^2: no exit! (return) by doc1623 (Novice) on Aug 14, 2015 at 17:45 UTC
No... `MATCHED IT insert value/count mismatch: no insert value entered pased*********************` [download]	[reply] [d/l]
Re^3: no exit! (return) by Corion (Patriarch) on Aug 14, 2015 at 17:53 UTC
Please restructure your code as follows: `if ($insql =~ m/.~\w+~./) { print "MATCHED IT\n";} errmsg(1); die; };` [download] You don't show the code of `errmsg`, but most likely it really returns a false value and thus prevents the `die` from executing.	[reply] [d/l] [select]
Re^3: no exit! (return) by stevieb (Canon) on Aug 14, 2015 at 18:08 UTC
If the left side of `&&` is false, the right side will never be executed. Compare: This does not die... `errstr() && die if (1); sub errstr { return 0; }` [download] This does: `if (1){ errstr(); die; } sub errstr { return 0; }` [download]	[reply] [d/l] [select]
Re: no exit! by Laurent_R (Canon) on Aug 14, 2015 at 18:56 UTC
Hmm, it is a bit difficult to answer your question when we don't know what the `dwindex` and `getinserts` subroutines do, and what the arguments ( the `$dbh`, `$script` and `$insert` parameters) are supposed to be.	[reply] [d/l] [select]