my ($node_ref,$error_ref)=get_node();
my @nodes=@$node_ref;
my @errorlist=@$error_ref;
[download]

return(\@serverlist, \@errorlist);
[download]

sub main {
my $path = 'E:/scripts/OutageNodes/';
require $path.'omwNodeDetails.pm';
open_log($path.'maintenanceMode_');
my $mode=get_mode();
my ($node_ref,$error_ref)=get_node();
my @nodes=@$node_ref;
my @errorlist=@$error_ref;
  if( $mode eq 'enable'){
        enable_unplanned_outage(@nodes);
                     }
  elsif($mode eq 'disable'){
        disable_unplanned_outage(@nodes);
               }
  else {
       printLog("Error invalid Mode $mode");
    }
    
    
printLog("There were ".scalar @errorlist." failed servers out of ".sca
+lar @nodes." in serverlist"); 
 
# clear serverlist
printLog ("Truncating serverlist");
open( SRV,'>',$path.'serverlist.txt') 
      or die "Can't open SRV '$path.serverlist': $!";
close SRV;
close_log();
}
[download]

sub get_node {

my @errorlist=();
my $sPath='e:/scripts/OutageNodes/';
my $sInFile=$sPath.'serverlist.txt';
my @sContent=();
my $sText;

##checks if the file exists and pulls the info out
      if (-e $sInFile){
    open INFILE, '<', $sInFile or die "Could not open $sInFile : $!";
    while (<INFILE>){
      chomp;
      $sText="$_";
      push @sContent,$sText;
      }
                                         
    close INFILE;
  }
  else {
    printLog("ERROR Cannot open $sInFile");
  } 
# check serverlist had entries
if (@sContent == 0){
    printLog("ERROR No nodes found in serverlist.txt");

    close_log();
       exit;
 } 
#get FQDN************

my $hostname;
my $fqdn;

my @serverlist;

for my $NODE (@sContent){
  ($hostname) = split /\./, $NODE;
  $fqdn = getNodeAttributes($hostname,'PrimaryNodeName');
      if(length($fqdn) < 1)
      { 
         printLog("No value returned from WMI, node ($NODE) doesn't ex
+ists in OMW.");
         push @errorlist,$fqdn;
         next;
      }  
    else {
    push(@serverlist,$fqdn);
  }
 }
return(\@serverlist, \@errorlist);
}
[download]

What does @nodes contain right before you call scalar() on it? You don't check in main() to see whether or not it is empty. Do enable_unplanned_outage() and disable_unplanned_outage() check to see whether there is anything in the array they are passed?

Also, if you just get an arrayref from get_node and only use it to pass it on to other subs (besides your print warning), why dereference it? You might as well pass the arrayref to the next sub and only dereference it when you need to use it.

The way forward always starts with a minimal test.

Also, if you just get an arrayref from get_node and only use it to pass it on to other subs (besides your print warning), why dereference it?

I can't speak for shroh, but I would derefence it anyway because I'm paranoid and want to avoid any chance of some function messing around with the content of the array. Even if I wrote the function myself - accidents happen. (I reserve passing a reference for cases where I do want to modify it or where copying the array has a noticeable impact on performance.)

Maybe one could

use Readonly;

...

Readonly my @result => do_some_computation();

do_something(\@result);
do_something_else(\@result);
[download]

but I haven't yet had a need to test out if this would really work as expected in all circumstances.

The @nodes contain the array of servers which i am passing to the other subs. Even in other subs(enable_unplanned_outage() , disable_unplanned_outage() i am able to use the same array without any issues. When i do a scaler on @errorlist i am able to get the exact number of elements in that array.

Great job. Thank you for the update.