in reply to simple OO constructor

There is also a school of thought (in which I'm enrolled {grin}) that an object should also be a "valid" object upon instantiation, and that a caller should never be given a partially constructed object that has to be prodded a bit before it would be valid for the rest of the program.

Since the point of an object is to hold varying internal state, creating an object with "new" that has no internal state almost certainly means that the object is not yet "initialized" and thus does not yet represent a valid object. (I can think of a few rare exceptions, but those are exactly that, rare.)

So, this "simple constructor" is nothing more than an interesting sequence of code, but in practical use, practically worthless.

In perlboot, I even argue that constructors shouldn't simply be called "new", since almost any real constructor will require some sort of state that cannot be determined without the use of parameters, and naming the method to match the intent of the parameters makes it somewhat clearer. As a practical famous example, note the constructor for DBI is called connect and not new. There's no way to create a "new DBI object". Only a connected one, one that has purpose and internal state and can be used with other calls. This is a very good model to follow.

-- Randal L. Schwartz, Perl hacker

Replies are listed 'Best First'.
(dws)Re: Re: simple OO constructor
by dws (Chancellor) on Sep 23, 2001 at 22:07 UTC
    There is also a school of thought (in which I'm enrolled {grin}) that an object should also be a "valid" object upon instantiation, and that a caller should never be given a partially constructed object that has to be prodded a bit before it would be valid for the rest of the program.

    Indeed. I've learned the hard way that approaches to OO that leave objects in an "I'm almost valid, really!" state are either asking for trouble now, or are investing in future trouble for the poor soul who picks up the code a year later, tries to extend it, and doesn't get the partial initialization exactly right.

    Clients of an API should never--at least never in production code--be handed invalid objects with the expectation that the client will do the right thing to get the object into a valid state.

    At the very least, this means that initialization parameters passed to new need to be honored. 

      sub new {
      my $proto = shift;
      bless { @_ }, ref($proto) || $proto;
  }
    This suffices to create instances of some simple objects, but often times setup is a bit more complicated. One pattern from the Smalltalk world is to separate initialization from instantiation, using a generic method for the latter, and a method for the former that subclasses can override.

    Using the pattern, the base class implements new (instantiation) and initialize (initialization). 

      sub new {
      my $proto = shift;
      my $self = bless { @_ }, ref($proto) || $proto;
      $self->initialize();
  }

  sub initialize {
      my $self = shift;
      ... initialization for the base class ...
  }

    [download]
    Subclasses then specialize the initialization. 
      sub initialize {
    my $self = shift;
    # First initialize our inherited aspects
    $self->SUPER::initialize();
    ... initialization specific to the subclass ...
  }

    [download]
    When I then create an instance of a subclass in this hierarchy, I get the generic new, followed by a pre-order invocation of initialize. I.e., first the object is initialized as if it is a member of the base class, and the initializations for subclasses happen in the order of refinement until I get down to the class I targeted. I end up with a fully initialized object.

    Using this scheme, at least with the class of objects for which this type of initialization works, I'm guaranteed to get a valid object back from new.

[reply]
[d/l]
[select]
Re: Re: simple OO constructor
by nothingmuch (Priest) on Feb 23, 2004 at 10:30 UTC
    What are your views on not returning a valid object, but fixing it transperrantly when needed? Object::Realize::Later is what I mean.
    -nuffin
    zz zZ Z Z #!perl
[reply]

In Section Cool Uses for Perl