Come on, afoken spent quite a bit of time to offer you a treasury of advice, and you seem to complain about it and claim you would have preferred "I don't like what you did"? That does not make sense to me. Downvoted.
I was intending to give a couple more pieces of advice, but it appears from your reaction that there is no point for me to waste my time.
As far as indenting I prefer to tab while others use spacing for portability.
I do not see how indenting with tabs (versus spaces) comes into play in, for example, this subroutine:
sub fmove {
my ($i,$data,$mvo,$mvn);
open($mvo,"<","$_[0]") or die $!; binmode($mvo);
open($mvn,">","$_[1]") or die $!; binmode($mvn);
while (($i=sysread $mvo,$data,4096)!=0){print $mvn $data};
close($mvn);close($mvo);unlink("$_[0]");
}
Also the arrays aren't identical due to the new folder tree having a different name. That's just how I did it.
Are you aware that when you pass two arrays to a subroutine, they get merged (or flattened out) into one single list, so that the arguments passed to, for example, your dircopy sub will work more or less properly only if you have only one source directory and only one target directory and that your code will fail for any other argument combination?
| [reply] [d/l] [select] |