in reply to Sports::Baseball::Teams
Worse yet, the following code fails (I think):
The reason is that a unique instance is not returned for a given team. Each new call asking for Seattle will return a distinct Seattle object. That's bad. Real bad.## first put all my favorite teams in a list: my @favorites = map { Sports::Baseball::Teams->new($_) } qw(Sea Tex An +a); ## now, let's notice a particular team playing tonight my $tonight = Sports::Baseball::Teams->new("Sea"); # seattle tonight ## let's see if this team playing tonight is one of my favorites: if (grep $_ == $tonight, @favorites) { ## THIS WON'T BE TRUE, BUT IT SHOULD BE }
There's your initial review. To get more details, you'll have to pay me. {grin}
If you wanna learn objects well, get Squeak and play with it a bit. Smalltalk rocks.
-- Randal L. Schwartz, Perl hacker
|
---|