Re^2: Break the foreach loop on count on 50 and then insert a new foreach loop

Another possibility (also untested):

use constant MAX => 50;

sub process_up_to_MAX_at_a_time {
    
    my ($port,       # comment
        @addresses,  # ...
        ) = @_;
        
    while (@addresses > MAX) {
        my @sub_group = splice @addresses, 0, MAX;
        process_0_to_MAX($port, @sub_group);
        }
    
    process_0_to_MAX($port, @addresses);

    }

sub process_0_to_MAX { ... }
[download]

See splice. process_up_to_MAX_at_a_time() could also be made purely recursive... if you're into that sort of thing.

BTW: Beware of comparisons like $#addresses >= 50 when checking array size: it's an off-by-one pitfall. It seems ok in the proces_no_more_than_50() example, but I find direct comparisons against an array (e.g., @addresses > 50) to be more intuitive and less error-prone in general. Also note that assignment to $[ (but don't do that!) changes the value of $#array (see perlvar). Evaluating @array in scalar context always yields the number of elements in the array. (The $[ special variable is deprecated as of Perl version 5.12; see the latest perlvar for its behavior after version 5.16. (Update: Better yet, check your local perldoc perlvar for its behavior on your system — and then don't touch it.))

Give a man a fish: <%-{-{-{-<

Comment on Re^2: Break the foreach loop on count on 50 and then insert a new foreach loop Select or Download Code

Replies are listed 'Best First'.
Re^3: Break the foreach loop on count on 50 and then insert a new foreach loop by Discipulus (Canon) on Nov 12, 2015 at 12:20 UTC
wise advices and good code AnomalousMonk! as usual iamnewbie be sure to understand the off-by-one pitfall explained by AnomalousMonk. L* There are no rules, there are no thumbs.. Reinvent the wheel, then learn The Wheel; may be one day you reinvent one of THE WHEELS.	[reply] [d/l]
Re^3: Break the foreach loop on count on 50 and then insert a new foreach loop by iamnewbie (Novice) on Nov 16, 2015 at 06:00 UTC
I had fixed my code with below resolution # Build up the match string portion of the iptables command: my @addresses2 = @$addresses; # Before Splice take backup in +to another variable while (scalar @addresses2) { my $matchString = "-m state"; $matchString .= " --state NEW"; $matchString .= " -m ${transport}"; $matchString .= " --protocol ${transport}"; $matchString .= " --dport ${portNum}"; $matchString .= " -s " . join(',', splice(@addresses2 +, 0, 50)); $matchString .= " -j ACCEPT"; # # Build the full command: my $cmd = "${appendCmd} --match=\"${matchString}\""; [download]	[reply] [d/l]
Re^3: Break the foreach loop on count on 50 and then insert a new foreach loop by iamnewbie (Novice) on Nov 13, 2015 at 06:19 UTC
Hi @AnomalousMonk Between i couldn't really understand what you mean here with your code can you please explain.	[reply]
Re^4: Break the foreach loop on count on 50 and then insert a new foreach loop by AnomalousMonk (Archbishop) on Nov 13, 2015 at 14:10 UTC
... i couldn't really understand what you mean here with your code ... Is it the code for `process_up_to_MAX_at_a_time()` or the discussion of the behavior of `$#array` (or both) that you are asking about? In either case, can you please be more specific about the points you do not understand? Give a man a fish: `<%-{-{-{-<`	[reply] [d/l] [select]