Most of the code is not being used at all… So the problem is probably that you are clobbering your hash somehow with the date stuff but you do not show it here. Or perhaps, judging by the modules you use, you aren’t creating the directories necessary before the move. Or maybe… this thing, File::PerlMove, is the culprit. Clobbering the move from File::Copy and having different usage. Try removing use File::PerlMove; and see if you get better error feedback.

I would also encourage you in another direction. This is simpler and has built in feedback for failures, which of course happens on my box.

use strictures;
use Path::Tiny;

my %files = ("e:/pervasive/staging/summit/C01" => "e:/pervasive/test/A
+PEX012015/C01",
             "e:/pervasive/staging/summit/C02" => "e:/pervasive/test/A
+PEX022015/C02",
             "e:/pervasive/staging/summit/C03" => "e:/pervasive/test/A
+PEX032015/C03", );

for my $key ( keys %files )
{
    my $original = path($key);
    my $destination = $files{$key};
    $original->move($destination);
}

__END__
moo@cow[88]~>perl pm/1150117.pl
Error rename on 'e:/pervasive/staging/summit/C01' -> 'e:/pervasive/tes
+t/APEX012015/C01': No such file or directory at pm/1150117.pl line 13
+.
[download]

Error rename on 'e:/pervasive/staging/summit/C01' -> 'e:/pervasive/tes
+t/APEX012015/C01': No such file or directory at pm/1150117.pl line 13
+.
[download]

This is now what I am running into. Any thoughts with dealing with this? It looks like it's searching for both the key -> value for the file path, or maybe I am misunderstanding the error.

It is trying to do just what it says; move file1 (hash key) to file2 (value for that key). The -> is not code, just part of the message. So we’ll add a check for the original and a mkpath for the destination (if necessary) before doing the move; but it seems like you probably don’t have it unzipped the way you think–

for my $key ( keys %files )
{
    my $original = path($key);
    die "There is no file $original" unless -f $original;
    my $destination = path($files{$key});
    $destination->parent->mkpath unless -d $destination->parent;
    $original->move($destination);
}
[download]

Or, does this mean that the destination directory does not exist? In a separate decompression script I have (unzipped all of these files to the staging area) it creates the folder for me, so my assumption was that path would have that built in.

Welcome Leetsauce,

If your script works for 1 ( then it will work for many ), then you only need to show us the following:

my %compHash =
   ( "e:/pervasive/staging/summit/C01" => "e:/pervasive/test/APEX01201
+5/C01",
   );

       foreach my $key(keys %compHash)
       {   my $value = $compHash{$key};
           my $ret = move($key , $value);
           if ( $ret )    ## If $ret == 1, then success
           {   print "Successfuly moved |$key| to |$value| .\n"; }
           else
           {   print "|$key| not moved to |$value|: $!\n"; }
    
       }
[download]

From the documentation from 'File::Copy', it states 'move' works on files. Are the keys and values you are working with directories?

Regards...Ed

Yes they are directories, and they have things inside them as well. Think that could be causing an issue? The for each that was posted before yours basically had the same result, with exception it was then telling me the new directory didn't exist.

Yes they are directories, and they have things inside them as well.

Take a look at File::Copy::Recursive

#!/usr/bin/perl
use strict;
use File::Copy::Recursive qw(dircopy dirmove);
use Time::Piece;

my $MDY = localtime->mdy('');
print "$MDY \n\n";

my $src  = 'e:/pervasive/staging/summit/';
my $dest = 'e:/pervasive/test/';

my @f = qw(01 02 03 04 05 06 07 08 30 
           40 41 42 43 44 44 50 80 85 99 );
           
my %compHash;
for my $n (@f[0]){ # replace with @f if it works for first
  $compHash{'C'.$n}         = 'APEX'.$n.'2015/C'.$n;
  $compHash{'C'.$n.'-2015'} = 'APEX'.$n.'2015/CSW';
};

foreach my $key (sort keys %compHash) {
  my $from = $src.$key;
  my $to   = $dest.$compHash{$key};
  print "Moving $from $to\n";
  dirmove ( $from,$to ) or die "$!"; 
}
[download]

poj

Leetsauce,

You can test for file or directory by:

     if ( -f $file ) { .... }     ## $file is a file
     elsif  ( -d $file ) { ... }  ## also could use '_' for speed
     else { ,,, }                 ## Not what we're looking for
[download]

Also you may wish to look at 'glob' for getting information about directory contents ( files and/or directories ).

Good Luck...Ed

"Well done is better than well said." - Benjamin Franklin

Now that I think about it, I could just create a new copy2 sub, and make it specifically deal with directories. I see the reference you're talking about now.

Thank you for pointing this out. Sorry about posting as much of the script as I did. I wanted to be able to get my point across, but, as you stated, if it worked for 1 it would work for whatever the cap on a foreach loop is in perl =p Thanks for your help! I ended up using your Foreach because it handled it the way I wanted.

Dear Leetsauce,

My point wasn't to criticize your elaborate script, but to help you get better answers in the future. I'm glad you found a viable solution, but you should think of this as the start of your journey. Perl will allow you to do some amazing things, but you have a lot to learn, and it shouldn't be painful.

Thank you for letting me know I helped you!

Good Luck and Best Regards...Ed

"Well done is better than well said." - Benjamin Franklin

Just a little note: I see you using tons of modules, but neither strict nor warnings. Consider adding them, even if they don't help solve your current issue.

Alexander

The modules you see are just from the template I started with ( a previous script I had written ) and I didn't bother to go back and remove what wasn't needed. That said; some are needed in areas of this that I did not show. I tried to keep whatever incriminating info out as much as I was able. Wouldn't want my company knowing I'm posting code used for business ops on an open forum =p That said; I don't care. You all are some of the most helpful, and promptly so, people I have ever met on the interwebz.