I have no comment on "mkdir -p".

If the match fails in loop, you would have bugs wherever you have used the captured variables for you don't skip that condition. Also, why do you regenerate file name when you already have it as the loop variable?