in reply to Re^7: Can't call method "proxy" on an undefined value at
in thread Can't call method "proxy" on an undefined value at

Thanks POJ, that is a so much nicer and cleaned of version of what I had. I guess it's a good lesson that I need to take more type and clean my stuff up. Quick question regarding output. My hope was that the script would step through and take the first city name from file1 + the 1st keyword name from line 1 + the first proxy from line 1 and use that for the first query and then do the same with the second, third, forth line and so on. It looks like it's using the 1st keyword with the 1st city and then going through all of the proxies. 

Keyword: [Myeloid+leukemia+lab]
Current proxy:1.0.251.108:8080
getting https://www.bing.com/search?q=San+Jose+CA+Myeloid+leukemia+lab
+&go=Submit&qs=n&form=QBLH&pq=San+Jose+CA+Myeloid+leukemia+lab&sc=0-25
+&sp=-1&sk=&cvid=ACB1AECE74E94CA8A48805667D1178F7
Creating Bing/San+Jose+CA_Myeloid+leukemia+lab_0.html
Wide character in print at slurpiegui17.pl line 214.

Current proxy:1.1.190.162:8080
getting https://www.bing.com/search?q=San+Jose+CA+Myeloid+leukemia+lab
+&go=Submit&qs=n&form=QBLH&pq=San+Jose+CA+Myeloid+leukemia+lab&sc=0-25
+&sp=-1&sk=&cvid=ACB1AECE74E94CA8A48805667D1178F7
Creating Bing/San+Jose+CA_Myeloid+leukemia+lab_1.html
Wide character in print at slurpiegui17.pl line 214.

Current proxy:1.161.42.95:8088
getting https://www.bing.com/search?q=San+Jose+CA+Myeloid+leukemia+lab
+&go=Submit&qs=n&form=QBLH&pq=San+Jose+CA+Myeloid+leukemia+lab&sc=0-25
+&sp=-1&sk=&cvid=ACB1AECE74E94CA8A48805667D1178F7
Creating Bing/San+Jose+CA_Myeloid+leukemia+lab_2.html
Wide character in print at slurpiegui17.pl line 214.

[download]

I'll take a look at it right now as well and see if I can figure out how to change it for the desired output. Should be much easier with such clean code. Who knows I might even be abel to figure it out. If I succeed I'll comment on this post. Thanks

Replies are listed 'Best First'.
Re^9: Can't call method "proxy" on an undefined value at
by poj (Abbot) on Feb 09, 2016 at 14:51 UTC

    OK, consider using shift in place of the inner loops

    for my $city (@cities) {
  my $keyword = shift @keywords;
  my $proxy   = shift @proxies; 
  .
  .

    [download]
    poj
[reply]
[d/l]

      Thanks. I understand the concept and see that the shift would and almost have it working. I'm getting an explicit package name error on $proxies. I'm using my $proxies earlier in the script so I"m not sure why I'm getting the error. I'll keep trying. Here's what I have. 

      # create useragent
    my $ua = LWP::UserAgent->new; 
    $ua->agent('Mozilla/8.0');

    # get pages for each city, keyword, proxy 
    
    for my $city (@cities) {
        my $keyword = shift @keywords;
        my $proxy   = shift @proxies;
        
     
        print "City :    [$city]\nKeyword: [$keyword]\n";

          print "Current proxy:$proxies\n";

          # Use this UA/Proxy to fetch something....
          $ua->proxy(['http'], 'http://'.$proxies);     
          my $url = join '',$link1 . $city ."+". $keyword,
                            $link2 . $city ."+". $keyword,
                            $link3;
          my $response = $ua->get($url);
          print "getting $url\n";      
          if ($response->is_success) {
            my $filename = "Bing/${city}_${keyword}.html";
            print "Creating $filename\n";
            open my $fh, ">", $filename 
                 or die("Could not open $filename. $!");
            print $fh $response->decoded_content;  # or whatever
            close $fh;
          } else {
            die $response->status_line;
          }
          print "\n"; 
        }
    close($fh);

      [download]

      These two lines are causing the errors:

          print "Current proxy:$proxies\n";

          # Use this UA/Proxy to fetch something....
          $ua->proxy(['http'], 'http://'.$proxies);

      [download]
[reply]
[d/l]
[select]
        @proxies, $proxy, and $proxies are three different variables. 
        ($q=q:Sq=~/;[c](.)(.)/;chr(-||-|5+lengthSq)`"S|oS2"`map{chr |+ord
}map{substrSq`S_+|`|}3E|-|`7**2-3:)=~y+S|`+$1,++print+eval$q,q,a,

        [download]
[reply]
[d/l]
[select]

        @proxies is the array. Use

           print "Current proxy:$proxy\n";
   # Use this UA/Proxy to fetch something....
   $ua->proxy(['http'], 'http://'.$proxy);

        [download]
        poj
[reply]
[d/l]
[select]

        OK, got it!

        # get pages for each city, keyword, proxy 
    
    for my $city (@cities) {
        my $keyword = shift @keywords;
        my $proxy   = shift @proxies;
        
     
        print "City :    [$city]\nKeyword: [$keyword]\n";

          print "Current proxy:$proxy)\n";

          # Use this UA/Proxy to fetch something....
          $ua->proxy(['http'], 'http://'.$proxy);     
          my $url = join '',$link1 . $city ."+". $keyword,
                            $link2 . $city ."+". $keyword,
                            $link3;
          my $response = $ua->get($url);
          print "getting $url\n";      
          if ($response->is_success) {
            my $filename = "Bing/${city}_${keyword}.html";
            print "Creating $filename\n";
            open my $fh, ">", $filename 
                 or die("Could not open $filename. $!");
            print $fh $response->decoded_content;  # or whatever
            close $fh;
          } else {
            die $response->status_line;
          }
          print "\n"; 
        }
    close($fh);

        [download]
[reply]
[d/l]

In Section Seekers of Perl Wisdom