in reply to Re: Segfault with Storable ( fixed )
in thread Segfault with Storable

Subtle detail. $timeout is now the time you are willing to spend between bytes. It isn't the total time you are willing to wait for another object. If you want to do that, then you need to test time elapsed in the loop condition and then redo if you don't select within a timeout that is reasonably small.

Another point. You are using a full tab indent. Studies indicate that code is easier to comprehend when the indent is in the range 2-4 characters. For more on that and general coding advice, I recommend picking up Code Complete.

  • Comment on Re (tilly) 2: Segfault with Storable ( fixed )

Replies are listed 'Best First'.
Re 3: ( timeout & tab ) Segfault with Storable
by lestrrat (Deacon) on Sep 29, 2001 at 05:32 UTC

    Thanks for the tips again --

    For the timeout, I'm still undecided if I want to put the extra effort in calculating the total time elapsed, or just deal with it the new way... For now I think I'll just reduce the timeouts. Something tells me this is better.

    And for the tabs, I just happened to copy the text from a machine where I didn't have vi aliased to vim... it wasn't reading my .vimrc( "set tabstop=4" ) :-)