Multiple items:

• I see no reason given the code provided, that this has to be done via eval. Do a $dbh->do($generated_table_data). I would recommend using the quoting or placeholder functions, if at all possible, of the dbi to avoid Bobby Tables issues.
• You are stringifying the reference for the $dbh, which is where the DBI::db=HASH... stuff is coming from. Don't do that. As I said in the last point, eval is not necessary here.

Note that quoting or placeholder functions will not work for database identifiers like table names, and only for content. So code like:

my $query = $dbh->prepare('CREATE TABLE ?');
$query->execute('TABLE_NAME');
[download]

will fail because the database engine will render that as

CREATE TABLE 'TABLE_NAME'
[download]

which is nonsense syntax.

---

#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.

Note that quoting or placeholder functions will not work for database identifiers like table names

DBI has a quote_identifier() method that handles all required quoting of database identifiers. Unfortunately, you can't use placeholders for identifiers, so you have to call quote_identifier() manually, like this:

my $cmd='create table '.$dbh->quote_identifier($tablename);
$dbh->do($cmd);
[download]

And by the way: There is also a quote() method in DBI. For all but some very exotic cases, just forget that it exists and use placeholders. I think quote() should die or at least warn when being called from non-DBI, non-DBD code. It is usually just wrong to use it instead of using placeholders. See Re: Counting rows Sqlite, Re^2: Massive Memory Leak, Re^3: Variable interpolation in a file to be read in, Re^5: Variable interpolation in a file to be read in for more details.

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

Thanks so much for the alternative approaches. I'll pick one.

L*

package PACK;
sub func {
    print "1\n";
}
package main;
$obj = bless {}, 'PACK';
$obj->func;
$str = "$obj->func;1";
eval $str or print $@;
[download]

This sounds a lot like an XY Problem. Why are you trying to do a string eval, instead of just the code

$dbh->do("CREATE TABLE STAIP08FK (PROBKEY varchar(20),MOBPAITS varchar
+(15),SOLVER varchar(10),UNKNOWNS char(11),CONSTRAINTS char(11),OBJECT
+IVE char(11),MODEL char(16),CRITERIA char(11),ITERATIONS integer,prim
+ary key (PROBKEY) );"
[download]

$str = qq{\$dbh->do("CREATE TABLE STAIP08FK (PROBKEY varchar(20),MOBPA
+ITS varchar(15),SOLVER varchar(10),UNKNOWNS char(11),CONSTRAINTS char
+(11),OBJECTIVE char(11),MODEL char(16),CRITERIA char(11),ITERATIONS i
+nteger,primary key (PROBKEY) );"};
[download]