The param function in CGI.pm already does all of this. It also handles other eventualities that you don't seem to have thought of (for example, what does your code do when the same CGI parameter appears twice?)

Please read use CGI or die;

--
<http://www.dave.org.uk>

"The first rule of Perl club is you don't talk about Perl club."