in reply to Factory Pattern in Perl6

(update: my first guess was wrong. See rest of this thread.)

My first guess is that your class declarations (which you didn't list) declare attributes without a public accessor rather than with one (ie you're using has $!foo instead of has $.foo). The official docs touch on this here. I'll discuss this more if it turns out to be the issue and you reply here requesting more info.

You didn't include enough code for me to confidently figure out what's going wrong. The first method works for me: 

use v6.c;
say $*PERL.compiler.version;

class ClassA {};
class ClassB {}
class ClassC {
    has $.foo;
    has $!bar;
};

my $class;
given 2 {
    when 0 { $class = ClassA }
    when 1 { $class = ClassB }
    default { $class = ClassC }
}

say my $obj = $class.new( foo => 1, bar => 1 );

[download]

This displays: 

v2016.04
ClassC.new(foo => 1)

[download]

The second method should work too. That's incorrect. An update to correct my mistake follows. To insert named arguments you need a container like my %args, eg: 

class ClassC { has $.foo }
my %args = :foo;
ClassC.new(|%args)

[download]

A Positional container as declared by my @args inserts positional arguments into an argument list. The "Default constructor ... only takes named arguments" comes up if you call a .new method that, through inheritance, calls the positional argument version of the new method from the root class Mu, eg: 

class C {}
C.new(1)

[download]

If you want a constructor that takes positional arguments you have to write one yourself like this one declared in the Duration class shipped with Perl 6: 

class Duration ... {
    has Rat $.tai = 0;
    ...
    method new($tai) { self.bless: tai => $tai.Rat }
    ...
}

[download]

So the Duration class's .new can accept a positional argument, eg: 

say Duration.new(22); # Duration.new(tai => 22.0)

[download]

Hopefully that's of some use.

»ö« . o O ( "the celebrity tell-all of the Perl-6 cult?" )

Replies are listed 'Best First'.
Re^2: Factory Pattern in Perl6
by hardburn (Abbot) on May 18, 2016 at 00:32 UTC

    Thanks for your reply. I had to set this project aside for a little while, but I was able to return to it tonight and whittle down the actual problem.

    After some playing around, the reason turned out to be the specific object being tested having a BUILDALL. Commenting out the BUILDALL method allowed the object to be constructed in the right class.

    To narrow it down from there, the BUILDALL started by calling callsame, as discussed in https://doc.perl6.org/language/objects. Changing that to nextsame (as shown in https://doc.perl6.org/language/traps) allowed the object to be constructed as expected.

    "There is no shame in being self-taught, only in not trying to learn in the first place." -- Atrus, Myst: The Book of D'ni.

[reply]
[d/l]
[select]
      If commenting out a custom BUILDALL fixes things then, almost certainly, the custom BUILDALL has a bug. If you share it I'll see if I can spot a bug.

      nextsame means about the same as callsame; return (but I think the compiler avoids the additional callframe on the stack), i.e. call the next multi candidate (with the exact same arguments) and don't bother running any more of the code that follows the nextsame.

      I would expect a multi method that starts with a nextsame to behave as if the method didn't exist, i.e. exactly the same as just commenting the method out. So your s/callsame/nextsame/ unfortunately doesn't narrow things down.

      »ö« . o O ( "the celebrity tell-all of the Perl-6 cult?" )

[reply]
[d/l]
[select]

        I put the full code up here: https://github.com/frezik/Games-Tetrachromat/tree/perl6_bug. It's demonstrated by doing:

        $ perl6 -I lib t/010_packet_ack.t 
1..7
Type check failed for return value; expected Game::Tetrachromat::Packe
+t but got Any (Any)
  in method read_packet at /home/tmurray/proj/Game-Tetrachromat/lib/Ga
+me/Tetrachromat/PacketFactory.pm6 (Game::Tetrachromat::PacketFactory)
+ line 79
  in block <unit> at t/010_packet_ack.t line 33

# Looks like you planned 7 tests, but ran 0

        [download]

        The factory is in lib/Game/Tetrachromat/PacketFactory.pm6, and the class it's supposed to be using for this test is lib/Game/Tetrachromat/Packet/Ack.pm6. All packet types do the role lib/Game/Tetrachromat/Packet.pm6.

        I was able to work around things by converting Game::Tetrachromat::Packet to a class instead of a role, and using BUILDALL for Packet::Ack. Inheritance is arguably the right way to go for this particular case, so I'll probably just leave it that way. Still, if there's a bug in perl6, I figured it was worth putting up the code that breaks it.

        "There is no shame in being self-taught, only in not trying to learn in the first place." -- Atrus, Myst: The Book of D'ni.

[reply]
[d/l]

In Section Seekers of Perl Wisdom