in reply to Script protector from a 'very' newbie..
If we want to discuss ur coding style, I can see a few things I'd like to point out:
when you open the file, it's good that you are checking for success, but since you're using or and not || you can drop the parens, and consider NOT hardcoding the filename in the statement:
$domainsfile = 'authoriseddomains.txt'; open DOM, $domainsfile or die "Can't open authoriseddomains.txt: $!\n" +;
proper indentation of your code will help you track bugs; if you do this, you will find an un-nessecary empty code block inside the first if
Then there's the error message, you are using this in a CGI script, so a great chance you are calling CGI.pm, so why not use it to print out the HTML nicely?
and one more thing about structure; if you move the error checking if ($sonuc != 1) code block after you close DOM you wouldn't need to run through it in every iteration.
just my 2 cents worth of blabering.
|
|---|